-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[incubator/kafka] fix commands documentation in NOTES.txt #22168
Conversation
Hi @zjgoodman. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Because the docker image's workdir is /opt/kafka and the binaries are in /opt/kafka/bin, the relative path './bin/' needs to be prepended to the binary calls in the `kubectl exec` commands Signed-off-by: Zach Goodman <zjgoodman@utexas.edu>
Signed-off-by: Zach Goodman <zjgoodman@utexas.edu>
/assign @benjigoldberg |
@unguiculus @benjigoldberg hey there, just wondering if this PR needs anything else from me before it can be reviewed & merged. This is my first time contributing here so I just wanna make sure everything's in order 👌 |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidkarlsen, zjgoodman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* add relative path to executable calls Because the docker image's workdir is /opt/kafka and the binaries are in /opt/kafka/bin, the relative path './bin/' needs to be prepended to the binary calls in the `kubectl exec` commands Signed-off-by: Zach Goodman <zjgoodman@utexas.edu> * bump chart version Signed-off-by: Zach Goodman <zjgoodman@utexas.edu>
* add relative path to executable calls Because the docker image's workdir is /opt/kafka and the binaries are in /opt/kafka/bin, the relative path './bin/' needs to be prepended to the binary calls in the `kubectl exec` commands Signed-off-by: Zach Goodman <zjgoodman@utexas.edu> * bump chart version Signed-off-by: Zach Goodman <zjgoodman@utexas.edu>
* add relative path to executable calls Because the docker image's workdir is /opt/kafka and the binaries are in /opt/kafka/bin, the relative path './bin/' needs to be prepended to the binary calls in the `kubectl exec` commands Signed-off-by: Zach Goodman <zjgoodman@utexas.edu> * bump chart version Signed-off-by: Zach Goodman <zjgoodman@utexas.edu>
* add relative path to executable calls Because the docker image's workdir is /opt/kafka and the binaries are in /opt/kafka/bin, the relative path './bin/' needs to be prepended to the binary calls in the `kubectl exec` commands Signed-off-by: Zach Goodman <zjgoodman@utexas.edu> * bump chart version Signed-off-by: Zach Goodman <zjgoodman@utexas.edu> Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
* add relative path to executable calls Because the docker image's workdir is /opt/kafka and the binaries are in /opt/kafka/bin, the relative path './bin/' needs to be prepended to the binary calls in the `kubectl exec` commands Signed-off-by: Zach Goodman <zjgoodman@utexas.edu> * bump chart version Signed-off-by: Zach Goodman <zjgoodman@utexas.edu> Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Is this a new chart
No
What this PR does / why we need it:
The existing Kafka chart's NOTES.txt has incorrect instructions.
Here's a short snippet of the post-install rendered notes
I copy/pasted the command provided to list kafka topics and this was the output
Because the Kafka docker image's workdir is /opt/kafka and the binaries are in /opt/kafka/bin, the relative path './bin/' needs to be prepended to the binary calls in the
kubectl exec
commandsWhich issue this PR fixes
N/A
Special notes for your reviewer:
N/A
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)