Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/locust] Fixes the format of the tolerations parameter #22134

Merged
merged 2 commits into from
May 4, 2020
Merged

[stable/locust] Fixes the format of the tolerations parameter #22134

merged 2 commits into from
May 4, 2020

Conversation

algattik
Copy link
Contributor

Fixes the format of the tolerations parameter. It was mistakenly set as a map, while Kubernetes expects an array.

Signed-off-by: Alexandre Gattiker algattik@users.noreply.github.com

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@algattik
Fixes the format of the tolerations parameter
c4e79c1 
Fixes the format of the tolerations parameter. It was mistakenly set as a map, while Kubernetes expects an array.

Signed-off-by: Alexandre Gattiker <algattik@users.noreply.github.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 26, 2020
@k8s-ci-robot k8s-ci-robot requested review from haugene and sekka1 April 26, 2020 16:52
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 26, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @algattik. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haugene
Copy link
Collaborator

haugene commented Apr 27, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 27, 2020
haugene
haugene approved these changes Apr 27, 2020
View reviewed changes
Copy link
Collaborator

@haugene haugene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@haugene
Copy link
Collaborator

haugene commented Apr 29, 2020

@algattik If you rebase against master now I think the test will run fine and we can merge this 👍

@algattik algattik requested a review from haugene May 3, 2020 12:03
@haugene
Copy link
Collaborator

haugene commented May 4, 2020

/retest

@haugene
Copy link
Collaborator

haugene commented May 4, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: algattik, haugene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit e3fe24e into helm:master May 4, 2020
bkimbrough88 pushed a commit to bkimbrough88/charts that referenced this pull request May 6, 2020
@algattik
Fixes the format of the tolerations parameter (helm#22134)
e5c34e4 
Fixes the format of the tolerations parameter. It was mistakenly set as a map, while Kubernetes expects an array.

Signed-off-by: Alexandre Gattiker <algattik@users.noreply.github.com>
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
@algattik
Fixes the format of the tolerations parameter (helm#22134)
06d8e56 
Fixes the format of the tolerations parameter. It was mistakenly set as a map, while Kubernetes expects an array.

Signed-off-by: Alexandre Gattiker <algattik@users.noreply.github.com>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@algattik @includerandom
Fixes the format of the tolerations parameter (helm#22134)
9fca0a5 
Fixes the format of the tolerations parameter. It was mistakenly set as a map, while Kubernetes expects an array.

Signed-off-by: Alexandre Gattiker <algattik@users.noreply.github.com>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@algattik @li-adrienloiseau
Fixes the format of the tolerations parameter (helm#22134)
b0ad019 
Fixes the format of the tolerations parameter. It was mistakenly set as a map, while Kubernetes expects an array.

Signed-off-by: Alexandre Gattiker <algattik@users.noreply.github.com>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@algattik
Fixes the format of the tolerations parameter (helm#22134)
b5f64c8 
Fixes the format of the tolerations parameter. It was mistakenly set as a map, while Kubernetes expects an array.

Signed-off-by: Alexandre Gattiker <algattik@users.noreply.github.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sekka1 sekka1 Awaiting requested review from sekka1

@haugene haugene Awaiting requested review from haugene

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@algattik @k8s-ci-robot @haugene @helm-bot