This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/newrelic-infrastructure] Fix templating for feature to disable KSM parsing #21712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Douglas Camata <dcamata@newrelic.com>
helm-bot
added
the
Contribution Allowed
helm-bot
added
the
size/XS
k8s-ci-robot
added
the
approved
4 tasks
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
…-infrastructure/fix-disable-ksm-feature
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: areina, douglascamata The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
irlevesque
pushed a commit
to quantopian/charts
that referenced
this pull request
Jul 13, 2020
Signed-off-by: Douglas Camata <dcamata@newrelic.com>
includerandom
pushed a commit
to includerandom/helm_charts
that referenced
this pull request
Jul 19, 2020
Signed-off-by: Douglas Camata <dcamata@newrelic.com>
li-adrienloiseau
pushed a commit
to li-adrienloiseau/charts
that referenced
this pull request
Jul 29, 2020
Signed-off-by: Douglas Camata <dcamata@newrelic.com> Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh
pushed a commit
to mmingorance-dh/charts
that referenced
this pull request
Aug 28, 2020
Signed-off-by: Douglas Camata <dcamata@newrelic.com> Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart
No.
What this PR does / why we need it:
Fixes a templating issue with the feature for disabling KSM parsing. Thanks to @sshishov for reporting it.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])