Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus-operator] Update Grafana chart dependency to include fix from #21442 #21562

Merged
merged 1 commit into from
Apr 2, 2020
Merged

[stable/prometheus-operator] Update Grafana chart dependency to include fix from #21442 #21562

merged 1 commit into from
Apr 2, 2020

Conversation

Annegies
Copy link
Contributor

Signed-off-by: Annegies van 't Zand ace.vtzand@gmail.com

What this PR does / why we need it:

This updates grafana to include the fix from #21442

Which issue this PR fixes

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@Annegies
Update Grafana chart dependency to include fix from helm#21442
e9b68c2 
Signed-off-by: Annegies van 't Zand <ace.vtzand@gmail.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Mar 21, 2020
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 21, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 21, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @Annegies. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Annegies
Copy link
Contributor Author

/assign @vsliouniaev

@vsliouniaev
Copy link
Collaborator

/ok-to-test
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Annegies, vsliouniaev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added ok-to-test approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 22, 2020
@Annegies
Copy link
Contributor Author

@vsliouniaev any idea why the pull-charts-e2e job is failing?

@Annegies
Copy link
Contributor Author

@vsliouniaev any idea why the pull-charts-e2e job is failing?

@vsliouniaev
Copy link
Collaborator

/retest

1 similar comment
@vsliouniaev
Copy link
Collaborator

/retest

@k8s-ci-robot k8s-ci-robot merged commit c260b1e into helm:master Apr 2, 2020
iuriaranda added a commit to skyscrapers/charts that referenced this pull request Apr 2, 2020
@iuriaranda
Update prometheus-operator version
6ab4c5d 
This new version includes a fix for Grafana (helm/charts#21562), and a fix for https://github.com/skyscrapers/engineering/issues/337
@iuriaranda iuriaranda mentioned this pull request Apr 2, 2020
Merged
iuriaranda added a commit to skyscrapers/charts that referenced this pull request Apr 2, 2020
@iuriaranda
Update prometheus-operator version (#102)
21c9c0a 
This new version includes a fix for Grafana (helm/charts#21562), and a fix for https://github.com/skyscrapers/engineering/issues/337
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
@Annegies
Update Grafana chart dependency to include fix from helm#21442 (helm#…
72c577d 
…21562)

Signed-off-by: Annegies van 't Zand <ace.vtzand@gmail.com>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@Annegies @includerandom
Update Grafana chart dependency to include fix from helm#21442 (helm#…
18c998a 
…21562)

Signed-off-by: Annegies van 't Zand <ace.vtzand@gmail.com>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@Annegies @li-adrienloiseau
Update Grafana chart dependency to include fix from helm#21442 (helm#…
c21b3e8 
…21562)

Signed-off-by: Annegies van 't Zand <ace.vtzand@gmail.com>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@Annegies
Update Grafana chart dependency to include fix from helm#21442 (helm#…
ac4dc2e 
…21562)

Signed-off-by: Annegies van 't Zand <ace.vtzand@gmail.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bismarck bismarck Awaiting requested review from bismarck

@vsliouniaev vsliouniaev Awaiting requested review from vsliouniaev

Assignees

@vsliouniaev vsliouniaev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stable/grafana Datasources added from chart config doesn't work but same datasource added manually works
4 participants
@Annegies @k8s-ci-robot @vsliouniaev @helm-bot