Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/nginx-ingress] fix service selector #21512

Merged
merged 2 commits into from
Mar 18, 2020
Merged

[stable/nginx-ingress] fix service selector #21512

merged 2 commits into from
Mar 18, 2020

Conversation

skomma
Copy link
Contributor

@skomma skomma commented Mar 18, 2020

Which issue this PR fixes

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

skomma added 2 commits March 18, 2020 11:54
@skomma
fixes helm#21508
f855095 
Signed-off-by: Syunsuke Komma <syunsuke@weseek.co.jp>
@skomma
bump chart version
f8b9f73 
Signed-off-by: Syunsuke Komma <syunsuke@weseek.co.jp>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 18, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @skomma. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skomma
Copy link
Contributor Author

skomma commented Mar 18, 2020

/assign @Tahara

@k8s-ci-robot
Copy link
Contributor

@skomma: GitHub didn't allow me to assign the following users: tahara.

Note that only helm members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @Tahara

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skomma
Copy link
Contributor Author

skomma commented Mar 18, 2020

/assign @taharah

@taharah
Copy link
Collaborator

taharah commented Mar 18, 2020

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skomma, taharah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2020
@skomma
Copy link
Contributor Author

skomma commented Mar 18, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1635fc3 into helm:master Mar 18, 2020
@skomma skomma mentioned this pull request Mar 18, 2020
Closed
@skomma skomma deleted the fix/issue-21508 branch March 18, 2020 17:51
@skomma skomma mentioned this pull request Mar 18, 2020
Merged
3 tasks
fowlie pushed a commit to fowlie/charts that referenced this pull request Mar 20, 2020
@skomma
[stable/nginx-ingress] fix service selector (helm#21512)
8400e21 
* fixes helm#21508

Signed-off-by: Syunsuke Komma <syunsuke@weseek.co.jp>

* bump chart version

Signed-off-by: Syunsuke Komma <syunsuke@weseek.co.jp>
@ElvenSpellmaker ElvenSpellmaker mentioned this pull request Apr 23, 2020
Closed
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
@skomma
[stable/nginx-ingress] fix service selector (helm#21512)
f914fd7 
* fixes helm#21508

Signed-off-by: Syunsuke Komma <syunsuke@weseek.co.jp>

* bump chart version

Signed-off-by: Syunsuke Komma <syunsuke@weseek.co.jp>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@skomma @includerandom
[stable/nginx-ingress] fix service selector (helm#21512)
7691ce8 
* fixes helm#21508

Signed-off-by: Syunsuke Komma <syunsuke@weseek.co.jp>

* bump chart version

Signed-off-by: Syunsuke Komma <syunsuke@weseek.co.jp>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@skomma @li-adrienloiseau
[stable/nginx-ingress] fix service selector (helm#21512)
49d9bd4 
* fixes helm#21508

Signed-off-by: Syunsuke Komma <syunsuke@weseek.co.jp>

* bump chart version

Signed-off-by: Syunsuke Komma <syunsuke@weseek.co.jp>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@skomma
[stable/nginx-ingress] fix service selector (helm#21512)
be900db 
* fixes helm#21508

Signed-off-by: Syunsuke Komma <syunsuke@weseek.co.jp>

* bump chart version

Signed-off-by: Syunsuke Komma <syunsuke@weseek.co.jp>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChiefAlexander ChiefAlexander Awaiting requested review from ChiefAlexander

@taharah taharah Awaiting requested review from taharah

Assignees

@taharah taharah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[stable/nginx-ingress] service selector doesn't match ingress controller labels
4 participants
@skomma @k8s-ci-robot @taharah @helm-bot