chore(nginx-ingress): fix hpa issue

[askhalil]

This will fix the issue where the HPA isn't able to read the metrics even when the resources of the controllers are set because the resources of the default-backend aren't set and both are using the same selectors

[k8s-ci-robot]

Hi @askhalil. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ChiefAlexander]

Selector labels on deployments are immutable and cannot be updated. This would be a major breaking change. Currently, there is work in progress to move this chart into the ingress-nginx repo and we are taking this opportunity to make breaking changes like this. Feel free to add this change there if it is not already fixed.

• https://github.com/kubernetes/ingress-nginx/tree/master/charts/ingress-nginx
• Helm chart TODO list kubernetes/ingress-nginx#5161

[askhalil]

@ChiefAlexander what if we make it as optional so people who will be using the chart for the first time they have the ability to allow it.

[ChiefAlexander]

That would be fine by me
/ok-to-test

[askhalil]

@ChiefAlexander I have updated the PR accordingly, so please have a look and approve it if it is okay

[ChiefAlexander]

This looks good. Other than the comment that I left can you also update the readme for this change. Once those two are resolved i'm good with this change.

[ChiefAlexander]

As we have added a feature to the chart please bump the minor version.

Suggested change

	version: 1.33.6
	version: 1.34.0

[askhalil]

@ChiefAlexander I have addressed both of you comments but please have a look at the readme file after the upadte

[ChiefAlexander]

/retest

[ChiefAlexander]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: askhalil, ChiefAlexander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stable/nginx-ingress/OWNERS [ChiefAlexander]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[otterley]

Unfortunately this introduced a regression that broke the connection between the controller service and the pods (the selector no longer matches). Can you please revert this change or fix forward? Also, please add a regression test so that this does not recur.

[dennybaa]

This is a regression. Breaks service monitor for instance #21873. Only half of the component labels have been changed why? If to change then to change all labels... Moreover app.kubernetes.io/component breaks prometheus and prometheus operator servicemonitor.