Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/mongodb-replicaset] Add support to customize updateStrategy #20968

Merged
merged 5 commits into from
Mar 17, 2020
Merged

[stable/mongodb-replicaset] Add support to customize updateStrategy #20968

merged 5 commits into from
Mar 17, 2020

Conversation

tuananhnguyen-ct
Copy link
Contributor

Signed-off-by: Tuan Anh Nguyen tuananh.nguyen-ext@commercetools.de

Is this a new chart

No

What this PR does / why we need it:

This adds support to specify the updateStrategy to mongodb statefulset if necessary.

In our current use case, we want to switch to OnDelete to manually rollout the change one by one since the dataset is large and could time out with normal helm upgrade.

Which issue this PR fixes

N/A

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@tuananhnguyen-ct
add support to customize updateStrategy
4cfc491 
Signed-off-by: Tuan Anh Nguyen <tuananh.nguyen-ext@commercetools.de>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Feb 24, 2020
@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 24, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 24, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @tuananhnguyen-ct. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zanhsieh
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 27, 2020
steven-sheehy
steven-sheehy suggested changes Mar 16, 2020
View reviewed changes
Copy link
Collaborator

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

stable/mongodb-replicaset/Chart.yaml Outdated Show resolved Hide resolved
@tuananhnguyen-ct
bump Chart version
6abea57 
Signed-off-by: Tuan Anh Nguyen <tuananh.nguyen-ext@commercetools.de>
@tuananhnguyen-ct
bump Chart version
b6a262e 
Signed-off-by: Tuan Anh Nguyen <tuananh.nguyen-ext@commercetools.de>
@tuananhnguyen-ct
minor version bump
a48288b 
Signed-off-by: Tuan Anh Nguyen <tuananh.nguyen-ext@commercetools.de>
steven-sheehy
steven-sheehy approved these changes Mar 17, 2020
View reviewed changes
Copy link
Collaborator

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: steven-sheehy, tuananhnguyen-ct

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit aa307a3 into helm:master Mar 17, 2020
fowlie pushed a commit to fowlie/charts that referenced this pull request Mar 20, 2020
@tuananhnguyen-ct
[stable/mongodb-replicaset] Add support to customize updateStrategy (h…
3e41679 
…elm#20968)

* add support to customize updateStrategy

Signed-off-by: Tuan Anh Nguyen <tuananh.nguyen-ext@commercetools.de>

* minor version bump

Signed-off-by: Tuan Anh Nguyen <tuananh.nguyen-ext@commercetools.de>
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
@tuananhnguyen-ct
[stable/mongodb-replicaset] Add support to customize updateStrategy (h…
7fbcfc9 
…elm#20968)

* add support to customize updateStrategy

Signed-off-by: Tuan Anh Nguyen <tuananh.nguyen-ext@commercetools.de>

* minor version bump

Signed-off-by: Tuan Anh Nguyen <tuananh.nguyen-ext@commercetools.de>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@tuananhnguyen-ct @includerandom
[stable/mongodb-replicaset] Add support to customize updateStrategy (h…
1ad0c94 
…elm#20968)

* add support to customize updateStrategy

Signed-off-by: Tuan Anh Nguyen <tuananh.nguyen-ext@commercetools.de>

* minor version bump

Signed-off-by: Tuan Anh Nguyen <tuananh.nguyen-ext@commercetools.de>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@tuananhnguyen-ct @li-adrienloiseau
[stable/mongodb-replicaset] Add support to customize updateStrategy (h…
a6be6bc 
…elm#20968)

* add support to customize updateStrategy

Signed-off-by: Tuan Anh Nguyen <tuananh.nguyen-ext@commercetools.de>

* minor version bump

Signed-off-by: Tuan Anh Nguyen <tuananh.nguyen-ext@commercetools.de>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@tuananhnguyen-ct
[stable/mongodb-replicaset] Add support to customize updateStrategy (h…
9392e92 
…elm#20968)

* add support to customize updateStrategy

Signed-off-by: Tuan Anh Nguyen <tuananh.nguyen-ext@commercetools.de>

* minor version bump

Signed-off-by: Tuan Anh Nguyen <tuananh.nguyen-ext@commercetools.de>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steven-sheehy steven-sheehy steven-sheehy approved these changes

@unguiculus unguiculus Awaiting requested review from unguiculus

Assignees

@steven-sheehy steven-sheehy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tuananhnguyen-ct @k8s-ci-robot @zanhsieh @steven-sheehy @helm-bot