This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/spinnaker] update spinnaker dependencies #20917
Next
Next commit
[stable/spinnaker] update spinnaker dependencies
Signed-off-by: Robbert Rijkse <rrijkse@homex.com>
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| dependencies: | ||
| - name: redis | ||
| repository: https://kubernetes-charts.storage.googleapis.com/ | ||
| version: 10.5.3 | ||
| - name: minio | ||
| repository: https://kubernetes-charts.storage.googleapis.com/ | ||
| version: 5.0.9 | ||
| digest: sha256:1346f1384895df16b51b5b8449d968a692e04f641c8580c284d43e755bb10c55 | ||
| generated: "2020-02-20T14:24:49.956216-05:00" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| dependencies: | ||
| - name: redis | ||
| version: 10.5.3 | ||
| repository: https://kubernetes-charts.storage.googleapis.com/ | ||
| condition: redis.enabled | ||
| - name: minio | ||
| version: 5.0.9 | ||
|
There was a problem hiding this comment. Since this is a massive chart change, did you address the possibility of any core changes in the mini chart? There might have been some variables moved round. There was a problem hiding this comment. Your right I had Minio disabled and it does not deploy (I had it turned off on mine). I committed new defaults that worked in a test environment. There was a problem hiding this comment. Wanted to add: This is the reason I bumped the minor version number of the chart instead of the patch version, this may require a major version bump depending on what your thoughts are. People will have to update their Minio settings and possibly their Redis settings. |
||
| repository: https://kubernetes-charts.storage.googleapis.com/ | ||
| condition: minio.enabled | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a massive chart change, did you address the possibility of any core changes in the redis chart? There might have been some variables moved round.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the default in values.yaml (which is all I'm using) the redis service/pod deploys without issue.