Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/sonarqube] upgrades LTS to latest patch #19836

Merged
merged 2 commits into from
Jan 14, 2020
Merged

[stable/sonarqube] upgrades LTS to latest patch #19836

merged 2 commits into from
Jan 14, 2020

Conversation

usmonster
Copy link
Contributor

Also updates ingress apiVersion, adding support for later k8s versions.
(Modernizes documentaiton accordingly.)

Signed-off-by: Usman Akeju akeju00+github@gmail.com

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

Nope!

What this PR does / why we need it:

It upgrades the stable SonarQube chart to refer to the latest patch of its LTS version.
It also makes the chart installable on Kubernetes >= 1.16. (see also #19023)

Which issue this PR fixes

Special notes for your reviewer:

I had to add the apiVersion update in order to test it.
As such, this pull request can probably supersede #19023.

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 2, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @usmonster. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 2, 2020
lachie83
lachie83 reviewed Jan 2, 2020
View reviewed changes
stable/sonarqube/templates/ingress.yaml Outdated Show resolved Hide resolved
REVIEW_GUIDELINES.md Outdated Show resolved Hide resolved
@usmonster usmonster requested a review from lachie83 January 3, 2020 11:26
@davidkarlsen
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 3, 2020
@usmonster usmonster mentioned this pull request Jan 6, 2020
Closed
4 tasks
@usmonster
Copy link
Contributor Author

/assign @mattfarina

@usmonster
Copy link
Contributor Author

poke @rjkernick @lachie83 @tsiddique for a /lgtm? 🙏
Thanks in advance!

@usmonster usmonster force-pushed the stable-sonarqube-7.9.2 branch from 02d70c9 to 510a677 Compare January 14, 2020 11:15
@usmonster
Copy link
Contributor Author

I had to rebase after a recent merge to master introduced a conflict with the chart version.

Please re-review/approve? 🙏

(re-poke @rjkernick @lachie83 @tsiddique)

@usmonster
[stable/sonarqube] upgrades LTS to latest patch
a16f5c1 
Also updates ingress apiVersion, adding support for later k8s versions.
(Modernizes documentaiton accordingly.)

Signed-off-by: Usman Akeju <akeju00+github@gmail.com>
@usmonster
[stable/sonarqube] support also k8s <= v1.13
a9a490e 
Signed-off-by: Usman Akeju <akeju00+github@gmail.com>
@usmonster usmonster force-pushed the stable-sonarqube-7.9.2 branch from 510a677 to a9a490e Compare January 14, 2020 12:45
@rjkernick
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2020
@rjkernick
Copy link
Collaborator

/assign

@rjkernick
Copy link
Collaborator

/lgtm

@rjkernick
Copy link
Collaborator

/approve

@usmonster
Copy link
Contributor Author

Thanks for the approval! Re-ping @mattfarina for a little /approve to complete the process? 🙏

@usmonster
Copy link
Contributor Author

usmonster commented Jan 14, 2020 •
edited
Loading

Ooooor...
/unassign @mattfarina
😅

Edit: It was worth a try 🤷‍♂

@scottrigby
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rjkernick, scottrigby, usmonster

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9402a76 into helm:master Jan 14, 2020
landorg pushed a commit to landorg/charts that referenced this pull request Jan 15, 2020
@usmonster @landorg
[stable/sonarqube] upgrades LTS to latest patch (helm#19836)
6fd726a 
* [stable/sonarqube] upgrades LTS to latest patch

Also updates ingress apiVersion, adding support for later k8s versions.
(Modernizes documentaiton accordingly.)

Signed-off-by: Usman Akeju <akeju00+github@gmail.com>

* [stable/sonarqube] support also k8s <= v1.13

Signed-off-by: Usman Akeju <akeju00+github@gmail.com>
psionikangel pushed a commit to VilledeMontreal/charts that referenced this pull request Jan 15, 2020
@usmonster @psionikangel
[stable/sonarqube] upgrades LTS to latest patch (helm#19836)
1822405 
* [stable/sonarqube] upgrades LTS to latest patch

Also updates ingress apiVersion, adding support for later k8s versions.
(Modernizes documentaiton accordingly.)

Signed-off-by: Usman Akeju <akeju00+github@gmail.com>

* [stable/sonarqube] support also k8s <= v1.13

Signed-off-by: Usman Akeju <akeju00+github@gmail.com>
arturrez pushed a commit to arturrez/stable-charts that referenced this pull request Jan 28, 2020
@usmonster @k8s-ci-robot
[stable/sonarqube] upgrades LTS to latest patch (helm#19836)
e2d7a2c 
* [stable/sonarqube] upgrades LTS to latest patch

Also updates ingress apiVersion, adding support for later k8s versions.
(Modernizes documentaiton accordingly.)

Signed-off-by: Usman Akeju <akeju00+github@gmail.com>

* [stable/sonarqube] support also k8s <= v1.13

Signed-off-by: Usman Akeju <akeju00+github@gmail.com>
Signed-off-by: Artur <artur@upbound.io>
arturrez pushed a commit to arturrez/stable-charts that referenced this pull request Jan 28, 2020
@usmonster
[stable/sonarqube] upgrades LTS to latest patch (helm#19836)
0765731 
* [stable/sonarqube] upgrades LTS to latest patch

Also updates ingress apiVersion, adding support for later k8s versions.
(Modernizes documentaiton accordingly.)

Signed-off-by: Usman Akeju <akeju00+github@gmail.com>

* [stable/sonarqube] support also k8s <= v1.13

Signed-off-by: Usman Akeju <akeju00+github@gmail.com>
Signed-off-by: Artur <artur@upbound.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rjkernick rjkernick Awaiting requested review from rjkernick

@tsiddique tsiddique Awaiting requested review from tsiddique

@lachie83 lachie83 Awaiting requested review from lachie83

Assignees

@rjkernick rjkernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
8 participants
@usmonster @k8s-ci-robot @davidkarlsen @rjkernick @scottrigby @lachie83 @mattfarina @helm-bot