Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/nginx-ingress] Add Validation webhook for nginx ingress controller #17230

Merged
merged 2 commits into from
Sep 20, 2019
Merged

[stable/nginx-ingress] Add Validation webhook for nginx ingress controller #17230

merged 2 commits into from
Sep 20, 2019

Conversation

LucasBoisserie
Copy link
Contributor

@LucasBoisserie LucasBoisserie commented Sep 18, 2019 •
edited
Loading

Is this a new chart

No

What this PR does / why we need it:

Nginx-ingress controller add a Validation webhook in 0.25 for ingress object
Add deployment inside helm chart

Which issue this PR fixes

None

Special notes for your reviewer:

Implementation is inspired by the prometheus operator webhooks

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@helm-bot helm-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 18, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @LucasBoisserie. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 18, 2019
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). and removed Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Sep 18, 2019
@LucasBoisserie
Copy link
Contributor Author

/assign @ChiefAlexander

@ChiefAlexander
Copy link
Collaborator

/ok-to-test

Can you also add a test to https://github.com/helm/charts/tree/master/stable/nginx-ingress/ci

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 18, 2019
@LucasBoisserie
Add Validation webhook for nginx ingress controller
8dfb055 
Signed-off-by: LucasBoisserie <lucas.boisserie@gmail.com>
@LucasBoisserie
add tests
6e2a45a 
Signed-off-by: LucasBoisserie <lucas.boisserie@gmail.com>
@LucasBoisserie
Copy link
Contributor Author

I add 4 tests for webhook and webhook with psp

@ChiefAlexander
Copy link
Collaborator

/lgtm
Thanks for this!

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChiefAlexander, LucasBoisserie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit 69afb2d into helm:master Sep 20, 2019
ramkumarvs pushed a commit to yugabyte/charts-helm-fork that referenced this pull request Sep 30, 2019
@LucasBoisserie
[stable/nginx-ingress] Add Validation webhook for nginx ingress contr…
408f0f6 
…oller (helm#17230)

* Add Validation webhook for nginx ingress controller

Signed-off-by: LucasBoisserie <lucas.boisserie@gmail.com>

* add tests

Signed-off-by: LucasBoisserie <lucas.boisserie@gmail.com>
ali-sattari pushed a commit to ali-sattari/charts that referenced this pull request Oct 7, 2019
@LucasBoisserie @ali-sattari
[stable/nginx-ingress] Add Validation webhook for nginx ingress contr…
301fa4f 
…oller (helm#17230)

* Add Validation webhook for nginx ingress controller

Signed-off-by: LucasBoisserie <lucas.boisserie@gmail.com>

* add tests

Signed-off-by: LucasBoisserie <lucas.boisserie@gmail.com>
Signed-off-by: Ali Sattari <ali.sattari@gmail.com>
@LucasBoisserie LucasBoisserie mentioned this pull request Apr 11, 2020
Merged
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChiefAlexander ChiefAlexander Awaiting requested review from ChiefAlexander

@taharah taharah Awaiting requested review from taharah

Assignees

@ChiefAlexander ChiefAlexander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LucasBoisserie @k8s-ci-robot @ChiefAlexander @helm-bot