This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/external-dns] no neeed for conditional on extraEnv any longer #15962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
helm-bot
added
Contribution Allowed
k8s-ci-robot
added
the
approved
juan131
approved these changes
Jul 30, 2019
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidkarlsen, juan131 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ThoTischner
pushed a commit
to bitsbeats/charts
that referenced
this pull request
Aug 13, 2019
…helm#15962) Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
landorg
pushed a commit
to landorg/charts
that referenced
this pull request
Aug 19, 2019
…helm#15962) Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com> Signed-off-by: Roland Gritzer <gritzer.roland@gmail.com>
kengou
pushed a commit
to kengou/charts
that referenced
this pull request
Sep 18, 2019
…helm#15962) Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
ramkumarvs
pushed a commit
to yugabyte/charts-helm-fork
that referenced
this pull request
Sep 30, 2019
…helm#15962) Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
gaida
pushed a commit
to gaida/charts
that referenced
this pull request
Oct 3, 2019
…helm#15962) Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David J. M. Karlsen david@davidkarlsen.com
What this PR does / why we need it:
#15900 made this conditional obsolete - hence removing.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/chart])