Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/seq] Version change to GA and add baseURI setting #14392

Merged
merged 2 commits into from
Jun 3, 2019

Conversation

jonstelly
Copy link
Contributor

@jonstelly jonstelly commented Jun 1, 2019

- Bump SEQ to GA 5.0 image tag
- Add setting for BASE_URI - Needed for Ingress and Azure Active Directory Authentication

What this PR does / why we need it:

Bumps SEQ image tag to GA version (5). Adds environment variable setting for BASE_URI which is needed to support Ingress and Azure AD. Without overriding and specifying HTTPS in the URL, SEQ will give a login redirect URL with HTTP and AAD only supports login redirects to HTTPS

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

jonstelly added 2 commits June 1, 2019 11:03
    - Bump SEQ to GA 5.0 image tag
    - Add setting for BASE_URI - Needed for Ingress and Azure Active Directory

Signed-off-by: Jon Stelly <967068+jonstelly@users.noreply.github.com>
Signed-off-by: Jon Stelly <967068+jonstelly@users.noreply.github.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jun 1, 2019
@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 1, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 1, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @jonstelly. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gertjvr
Copy link
Collaborator

gertjvr commented Jun 2, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 2, 2019
@gertjvr
Copy link
Collaborator

gertjvr commented Jun 3, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gertjvr, jonstelly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit e9e9066 into helm:master Jun 3, 2019
@jonstelly jonstelly deleted the seq/ga_base_uri branch June 10, 2019 18:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants