-
Notifications
You must be signed in to change notification settings - Fork 16.7k
[incubator/vault] tolerations and nodeSelector #11616
Conversation
dennybaa
commented
Feb 21, 2019
•
edited
Loading
edited
- Fixed affinity placement bug
- Added missing tolerations and nodeSelector
- liveness and readiness improvments
Hi @dennybaa. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
bcbca03
to
0bf9767
Compare
0bf9767
to
1412b49
Compare
1412b49
to
0770615
Compare
0770615
to
b9f8b15
Compare
b9f8b15
to
9849a93
Compare
9849a93
to
2f1c477
Compare
/assign unguiculus |
Signed-off-by: Denis Baryshev <dennybaa@gmail.com>
2f1c477
to
4a08075
Compare
Signed-off-by: Denis Baryshev <dennybaa@gmail.com>
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
/ok-to-test |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dennybaa, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dennybaa , this is great and helps resolve my oversight after originally changing the liveness check. I'm thinking of also adding a |
Related to #12043. |
@jbialy thanks. I totally agree |
* [incubator/vault] tolerations and nodeSelector Signed-off-by: Denis Baryshev <dennybaa@gmail.com> * [incubator/vault] liveness and readiness improvements Signed-off-by: Denis Baryshev <dennybaa@gmail.com> * Bump minor version for new features Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
* [incubator/vault] tolerations and nodeSelector Signed-off-by: Denis Baryshev <dennybaa@gmail.com> * [incubator/vault] liveness and readiness improvements Signed-off-by: Denis Baryshev <dennybaa@gmail.com> * Bump minor version for new features Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
* [incubator/vault] tolerations and nodeSelector Signed-off-by: Denis Baryshev <dennybaa@gmail.com> * [incubator/vault] liveness and readiness improvements Signed-off-by: Denis Baryshev <dennybaa@gmail.com> * Bump minor version for new features Signed-off-by: Reinhard Nägele <unguiculus@gmail.com> Signed-off-by: Kevin Duane <duank001@apps.disney.com>
* [incubator/vault] tolerations and nodeSelector Signed-off-by: Denis Baryshev <dennybaa@gmail.com> * [incubator/vault] liveness and readiness improvements Signed-off-by: Denis Baryshev <dennybaa@gmail.com> * Bump minor version for new features Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>