Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/vault] tolerations and nodeSelector #11616

Merged
merged 4 commits into from
Mar 14, 2019
Merged

[incubator/vault] tolerations and nodeSelector #11616

merged 4 commits into from
Mar 14, 2019

Conversation

dennybaa
Copy link
Contributor

@dennybaa dennybaa commented Feb 21, 2019 •
edited
Loading

  • Fixed affinity placement bug
  • Added missing tolerations and nodeSelector
  • liveness and readiness improvments

@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 21, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @dennybaa. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 21, 2019
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 21, 2019
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 21, 2019
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 21, 2019
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 21, 2019
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 21, 2019
@dennybaa dennybaa force-pushed the vault-tolerations branch from 9849a93 to 2f1c477 Compare March 13, 2019 12:40
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 13, 2019
@dennybaa
Copy link
Contributor Author

/assign unguiculus

@dennybaa
[incubator/vault] tolerations and nodeSelector
4a08075 
Signed-off-by: Denis Baryshev <dennybaa@gmail.com>
@dennybaa dennybaa force-pushed the vault-tolerations branch from 2f1c477 to 4a08075 Compare March 13, 2019 16:52
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 13, 2019
@dennybaa dennybaa changed the title [incubator/vault] tolerations and nodeSelector [incubator/vault] tolerations and nodeSelector #wip Mar 13, 2019
@dennybaa
[incubator/vault] liveness and readiness improvements
d6d582e 
Signed-off-by: Denis Baryshev <dennybaa@gmail.com>
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 13, 2019
@dennybaa dennybaa changed the title [incubator/vault] tolerations and nodeSelector #wip [incubator/vault] tolerations and nodeSelector Mar 13, 2019
@unguiculus
Bump minor version for new features
52e9cbc 
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 14, 2019
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 14, 2019
@unguiculus
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 14, 2019
@unguiculus
Copy link
Member

/ok-to-test

@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dennybaa, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1cd1614 into helm:master Mar 14, 2019
@jbialy
Copy link
Contributor

jbialy commented Mar 16, 2019

@dennybaa , this is great and helps resolve my oversight after originally changing the liveness check. I'm thinking of also adding a aliveIfSealed option configurable in the Values. Since technically Vault should be considered "alive" even if it's in a sealed state.

@jbialy
Copy link
Contributor

jbialy commented Mar 16, 2019

Related to #12043.

@jbialy jbialy mentioned this pull request Mar 16, 2019
Merged
3 tasks
@dennybaa
Copy link
Contributor Author

dennybaa commented Mar 17, 2019 •
edited
Loading

@jbialy thanks. I totally agree aliveIfSealed is absolutely feasible too, since some installation might use manual unseal and then it's a must.

rmccorm4 pushed a commit to rmccorm4/charts that referenced this pull request Mar 26, 2019
@dennybaa @rmccorm4
[incubator/vault] tolerations and nodeSelector (helm#11616)
e2b78d0 
* [incubator/vault] tolerations and nodeSelector

Signed-off-by: Denis Baryshev <dennybaa@gmail.com>

* [incubator/vault] liveness and readiness improvements

Signed-off-by: Denis Baryshev <dennybaa@gmail.com>

* Bump minor version for new features

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
crackmac pushed a commit to crackmac/charts that referenced this pull request Mar 29, 2019
@dennybaa
[incubator/vault] tolerations and nodeSelector (helm#11616)
90a2266 
* [incubator/vault] tolerations and nodeSelector

Signed-off-by: Denis Baryshev <dennybaa@gmail.com>

* [incubator/vault] liveness and readiness improvements

Signed-off-by: Denis Baryshev <dennybaa@gmail.com>

* Bump minor version for new features

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
crackmac pushed a commit to crackmac/charts that referenced this pull request Mar 29, 2019
@dennybaa
[incubator/vault] tolerations and nodeSelector (helm#11616)
bc7e1cb 
* [incubator/vault] tolerations and nodeSelector

Signed-off-by: Denis Baryshev <dennybaa@gmail.com>

* [incubator/vault] liveness and readiness improvements

Signed-off-by: Denis Baryshev <dennybaa@gmail.com>

* Bump minor version for new features

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
Signed-off-by: Kevin Duane <duank001@apps.disney.com>
devnulled pushed a commit to devnulled/charts that referenced this pull request Apr 25, 2019
@dennybaa @devnulled
[incubator/vault] tolerations and nodeSelector (helm#11616)
572c0e0 
* [incubator/vault] tolerations and nodeSelector

Signed-off-by: Denis Baryshev <dennybaa@gmail.com>

* [incubator/vault] liveness and readiness improvements

Signed-off-by: Denis Baryshev <dennybaa@gmail.com>

* Bump minor version for new features

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
@any1th3r3 any1th3r3 mentioned this pull request May 22, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sameersbn sameersbn Awaiting requested review from sameersbn

@unguiculus unguiculus Awaiting requested review from unguiculus

Assignees

@unguiculus unguiculus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dennybaa @k8s-ci-robot @unguiculus @jbialy @helm-bot