This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/drone] fixing server.protocol and NOTES.txt
#10971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Williams <max.williams@deliveryhero.com>
helm-bot
added
Contribution Allowed
|
/assign @christian-roggia |
| @@ -6,7 +6,7 @@ | |||
| {{- if .Values.ingress.enabled }} | |||
| From outside the cluster, the server URL(s) are: | |||
| {{- range .Values.ingress.hosts }} | |||
| http://{{ . }} | |||
| {{ $.Values.server.protocol }}://{{ . }} | |||
There was a problem hiding this comment.
Why the $ before .Values.server.protocol?
There was a problem hiding this comment.
Because of the scope. Here we are in a loop so you can't access the parent scope without it. You get this error without it:
Error: render error in "drone/templates/NOTES.txt": template: drone/templates/NOTES.txt:9:8: executing "drone/templates/NOTES.txt" at <.>: can't give argument to non-function .
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christian-roggia, max-rocket-internet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
syedimam0012
pushed a commit
to syedimam0012/charts
that referenced
this pull request
Feb 1, 2019
Signed-off-by: Max Williams <max.williams@deliveryhero.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I think this value should be without
://?Also updating
NOTES.txtto use this value when ingress is used.Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]