Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/datadog] Update default value of datadog.livenessProbe in README #10876

Merged
merged 2 commits into from
Jan 29, 2019
Merged

[stable/datadog] Update default value of datadog.livenessProbe in README #10876

merged 2 commits into from
Jan 29, 2019

Conversation

rbmrclo
Copy link
Contributor

@rbmrclo rbmrclo commented Jan 24, 2019

What this PR does / why we need it:

  • The default value for datadog.livenessProbe has been updated by this PR: Datadog helm update #10827
  • This keeps the documentation updated and could save other people's time when debugging the problem which the new default value might cause. (In my case, we are still respecting the former default probe.sh)

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 24, 2019
@k8s-ci-robot k8s-ci-robot requested review from CharlyF and hkaj January 24, 2019 14:41
@rbmrclo rbmrclo changed the title [Datadog] Update default value of datadog.livenessProbe in README [stable/datadog] Update default value of datadog.livenessProbe in README Jan 26, 2019
@rbmrclo
Copy link
Contributor Author

rbmrclo commented Jan 26, 2019

/assign @CharlyF @hkaj

CharlyF
CharlyF suggested changes Jan 29, 2019
View reviewed changes
Copy link
Collaborator

@CharlyF CharlyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rbmrclo - Thank you for this PR!
I double checked and the http liveness probe was only implemented in the version 6.8.0 of the agent:
https://github.com/DataDog/datadog-agent/pull/2359/files

Any chance you can bump the version of the agent (appVersion) in the Chart.yaml and the tag in the values.yaml to the newest 6.9.0 ?

I will take another pass at this PR after.
.C

@rbmrclo
Change default value of datadog.livenessProbe in README
1ca9e26 
Signed-off-by: Robbie Marcelo <rbmrclo@hotmail.com>
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Jan 29, 2019
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 29, 2019
@rbmrclo
Bump version to 1.18.1
0cfba76 
Signed-off-by: Robbie Marcelo <rbmrclo@hotmail.com>
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 29, 2019
@rbmrclo
Copy link
Contributor Author

rbmrclo commented Jan 29, 2019

Hi @CharlyF,

I've noticed that the aforementioned requests were already updated in the latest stable so I just rebased my branch off the upstream branch.

Thanks for taking time to review 🙏

@CharlyF
Copy link
Collaborator

CharlyF commented Jan 29, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlyF, rbmrclo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit faddc35 into helm:master Jan 29, 2019
syedimam0012 pushed a commit to syedimam0012/charts that referenced this pull request Feb 1, 2019
@rbmrclo @syedimam0012
[stable/datadog] Update default value of datadog.livenessProbe in REA…
0ee0ad3 
…DME (helm#10876)

* Change default value of datadog.livenessProbe in README

Signed-off-by: Robbie Marcelo <rbmrclo@hotmail.com>

* Bump version to 1.18.1

Signed-off-by: Robbie Marcelo <rbmrclo@hotmail.com>
@elliottgorrell elliottgorrell mentioned this pull request Feb 6, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CharlyF CharlyF CharlyF requested changes

@hkaj hkaj Awaiting requested review from hkaj

Assignees

@hkaj hkaj

@CharlyF CharlyF

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rbmrclo @CharlyF @k8s-ci-robot @hkaj @helm-bot