This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/rocketchat] Allow disabling MongoDB dependency #10875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Bickel <lucas.bickel@adfinis-sygroup.ch>
helm-bot
added
Contribution Allowed
Signed-off-by: Lucas Bickel <lucas.bickel@adfinis-sygroup.ch>
helm-bot
added
size/S
|
/assign @verwilst |
|
/ok-to-test |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidkarlsen, hairmare The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
syedimam0012
pushed a commit
to syedimam0012/charts
that referenced
this pull request
Feb 1, 2019
* Allow disabling MongoDB dependency Signed-off-by: Lucas Bickel <lucas.bickel@adfinis-sygroup.ch> * Update chart requirements Signed-off-by: Lucas Bickel <lucas.bickel@adfinis-sygroup.ch>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allow disabling MongoDB depdency. Allows users of the chart to completely skip deploying MongoDB while still allowing the MONGO_URL env var to be configured through helm.
This makes it possible to "bring your own MongoDB" (ie. by using MongoDB Atlas or any othre MongoDB-as-a-service provider).
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]