Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/mariadb] Add support to existing configMaps as init scripts #10338

Merged
merged 1 commit into from
Jan 2, 2019
Merged

[stable/mariadb] Add support to existing configMaps as init scripts #10338

merged 1 commit into from
Jan 2, 2019

Conversation

juan131
Copy link
Collaborator

@juan131 juan131 commented Jan 2, 2019

Signed-off-by: juan131 juan@bitnami.com

What this PR does / why we need it:

This PR allows the user to use an existing configMap with initdb scripts when deploying the MariaDB chart. It also adds support to indicate the list of initdb scripts as a parameter in the values.yaml.

Which issue this PR fixes

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Jan 2, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2019
@juan131
Copy link
Collaborator Author

juan131 commented Jan 2, 2019

/assign @tompizmor

Copy link
Collaborator

@tompizmor tompizmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juan131, tompizmor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit 96e19d6 into helm:master Jan 2, 2019
@juan131 juan131 deleted the mariadb_initdb_scripts branch January 2, 2019 15:20
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[stable/mariadb] files/docker-entrypoint-initdb.d/* on parent chart doesn't work
4 participants