Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/rocketchat] Add option to use existing PVC #22262

Closed
varac opened this issue May 5, 2020 · 4 comments · Fixed by #22994
Closed

[stable/rocketchat] Add option to use existing PVC #22262

varac opened this issue May 5, 2020 · 4 comments · Fixed by #22994

Comments

@varac
Copy link
Contributor

varac commented May 5, 2020

Is your feature request related to a problem? Please describe.

We want to provide human redeable PV names and therefor create persistant volumes + claims ourselves, and need to use these for this chart. But there's no existingClaim option for rocketchat so far.

Describe the solution you'd like

Add an persistence.existingClaim value to the chart.

Describe alternatives you've considered

None.

Additional context

Many other helm charts allow the usage of existing claims.
@stale
Copy link

stale bot commented Jun 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 5, 2020
@mrtndwrd
Copy link
Contributor

mrtndwrd commented Jun 5, 2020

This issue is still relevant

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 5, 2020
mrtndwrd pushed a commit to greenhost/charts that referenced this issue Jun 29, 2020
Add persistence.existingClaim configuration, closes helm#22262
73125c0 
Signed-off-by: Maarten de Waard <maarten@greenhost.nl>
mrtndwrd pushed a commit to greenhost/charts that referenced this issue Jun 29, 2020
Add persistence.existingClaim configuration, closes helm#22262
1fd8b1b 
Signed-off-by: Maarten de Waard <maarten@greenhost.nl>
@mrtndwrd mrtndwrd mentioned this issue Jun 29, 2020
Merged
4 tasks
@stale
Copy link

stale bot commented Jul 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 5, 2020
@varac
Copy link
Contributor Author

varac commented Jul 5, 2020

Please merge #22994 !

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 5, 2020
k8s-ci-robot pushed a commit that referenced this issue Jul 28, 2020
Add persistence.existingClaim configuration, closes #22262 (#22994)
99447d7 
Signed-off-by: Maarten de Waard <maarten@greenhost.nl>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this issue Jul 29, 2020
@li-adrienloiseau
Add persistence.existingClaim configuration, closes helm#22262 (helm#…
db0e62e 
…22994)

Signed-off-by: Maarten de Waard <maarten@greenhost.nl>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this issue Aug 28, 2020
Add persistence.existingClaim configuration, closes helm#22262 (helm#…
78e09dd 
…22994)

Signed-off-by: Maarten de Waard <maarten@greenhost.nl>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[stable/rocketchat] Add persistence.existingClaim configuration, closes #22262 greenhost/charts
2 participants
@varac @mrtndwrd