Fix chart_schema.yaml import-values rule #725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
The existing rule for validating dependency import-values worked well for either of these two cases:
**1. Importing exports**
```yaml
dependencies:
- name: dep1
version: 0.14.1
repository: oci://myrepo
import-values:
- data
```
**2. Importing child values into the parent**
```yaml
dependencies:
- name: dep1
version: 0.14.1
repository: oci://myrepo
import-values:
- child: default.data
parent: myimports
```
However, it failed on the following valid usecase:
```yaml
dependencies:
- name: dep1
version: 0.14.1
repository: oci://myrepo
import-values:
- data
- child: default.data
parent: myimports
```
Giving the following error:
```
dependencies.0.import-values.1: '{'parent': 'myimports', 'child': 'default.data'}' is not a str.
dependencies.0.import-values.0 : 'data' is not a map
```
This is because the Yamale is validating on a list of strings *or* a list of `import-value`, where a list containing both is also valid.
This commit changes the rule to allow both methods to be in the `import-values` list.
Signed-off-by: Ben Lavery-Griffiths <ben@lavery-griffiths.com>
forquare
force-pushed
the
fix-chart-yaml-schema-import-values
branch
from
0d05531 to
0d5f4f4
Compare
|
Today I have posted in the #helm-chart-testing Slack channel hoping to make some progress with the PR and to remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The existing rule for validating dependency import-values worked well for either of these two cases:
1. Importing exports
2. Importing child values into the parent
However, it failed on the following valid usecase:
Giving the following error:
This is because the Yamale is validating on a list of strings or a list of
import-value, where a list containing both is also valid.This commit changes the rule to allow both methods to be in the
import-valueslist.