Reduce container size #352
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellt
requested changes
Jun 6, 2025
There was a problem hiding this comment.
thanks @evilhamsterman !
I had a few comments; nothing too major
| @@ -1,10 +1,22 @@ | |||
| FROM public.ecr.aws/docker/library/debian:bookworm-slim | |||
There was a problem hiding this comment.
we should keep the ecr.aws registry. Docker's pull limits are the reason
| COPY $IMAGE* / | ||
| RUN qemu-img resize /$IMAGE $DISK_SIZE | ||
|
|
||
| FROM debian:bookworm-slim |
There was a problem hiding this comment.
same comment for the image registry as above
| COPY *.py / | ||
| COPY --chmod=0755 backup.sh / |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dockerfile for these images would copy in the image file then run
qemu-img resize IMAGE DISK_SIZE, because of the way container layers work that means you end up with two copies of the image in the container, one of which is unusable. This effectively doubles the container size.Also I added
--no-install-recommendsas without it hundreds of unneeded packages such as fonts are installed.This takes the Ubuntu image from 2.24GB to 950MB