Support Huawei AR1000V #329
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vista-
suggested changes
Mar 4, 2025
| self.wait_write(cmd="protocol inbound ssh port 830", wait="]") | ||
| #self.wait_write(cmd="quit", wait="]") | ||
|
|
||
| # Envia o comando commit inicialmente |
There was a problem hiding this comment.
Could you please change these comments to be in English?
| self.spins += 1 | ||
|
|
||
| return | ||
|
|
||
| def bootstrap_mgmt_interface(self): | ||
| self.wait_write(cmd="mmi-mode enable", wait=None) | ||
| #self.wait_write(cmd="mmi-mode enable", wait=None) |
There was a problem hiding this comment.
Would this not break the other Huawei VMs' configuration?
As far as I can tell, this disables the verification prompts for certain configuration commands.
Later, the code also undoes this, so I'm not sure where this would be set.
|
|
||
| if match: | ||
| if ridx == 0: # Mensagem de erro ao tentar commit | ||
| print("Sistema ocupado, aguardando 5 segundos para tentar novamente...") |
There was a problem hiding this comment.
Same here about language. Also, don't print to stdout, but rather use the logger.
| self.wait_write(cmd="snetconf server enable", wait="]") | ||
| self.wait_write(cmd="netconf", wait="]") | ||
| self.wait_write(cmd="protocol inbound ssh port 830", wait="]") | ||
| #self.wait_write(cmd="quit", wait="]") |
| self.wait_write(cmd="save", wait=">") | ||
| self.wait_write(cmd="undo mmi-mode enable", wait=">") | ||
|
|
||
| if self.vm_type == "AR1000V": |
|
@andrediashexa Have you perhaps had time to review my comments? I'm happy to help with getting this merged into vrnetlab! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even that AR1000V, the launch.py does not support this equipment.
Because of it, I developed this support, using the same logic of the project.