Skip to content

Implement Spirent vSTC #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 17, 2025
Merged

Implement Spirent vSTC #324

merged 9 commits into from
Feb 17, 2025

Conversation

kaelemc
Copy link

@kaelemc kaelemc commented Feb 17, 2025

vSTC is weird in that you have to reboot to apply config. Since there is no DHCP server to apply the passthrough address from clab, we enter the IP addressing manually. Then reboot the node.

This node has transparent mgmt passthrough force enabled, will not connect correctly with the QEMU NAT.

Unfortunately this means the node boot time is doubled, but this quick and dirty method does the trick.

@kaelemc
Copy link
Author

kaelemc commented Feb 17, 2025

@hellt Fixed

The explanation is that I copied the csr dir and then just made my changes to "implement" STC.

A few thoughts:

  • We should check over all images to make these changes to the Makefile (remove common build steps, change image naming requirements)
  • I think all Dockerfiles should use latest tag for the base image, if users need specific compatibility then they should manually edit the tag. This will make maintaining the Dockerfiles much easier (which is the intended purpose of the base image).

Let me know if anything else should be changed

@hellt hellt merged commit 29443d7 into hellt:master Feb 17, 2025
1 check was pending
wastrachan added a commit to gamersoutreach/vrnetlab that referenced this pull request Apr 19, 2025
* upstream/master: (184 commits)
  Fix and extend OpenWRT vrnetlab image for Containerlab compatibility (hellt#339)
  Add `DEBUG_SCRAPLI` env var (hellt#325)
  vJunos and vSRX improvements: interface count, base Docker image (hellt#342)
  fix ordering of linecards in distributed mode (hellt#336)
  PAN-OS: Handle version number suffix (hellt#333)
  Check for undefined mgmt IP (hellt#328)
  Implement Spirent vSTC (hellt#324)
  viosl2: add scrapli and new docker image (hellt#323)
  Add support for vJunosEvolved 24.2 and up (hellt#322)
  fix panos dockerfile (hellt#318)
  Copied Dockerfile from xrv9k/docker/Dockerfile to huawei_vrp/docker/Dockerfile which successfull allows the make for Huawei VRP now (hellt#315)
  remove old vrp code
  Implement Scrapli 'core' and platform migration [part 1] (hellt#306)
  DHCP and static MAC support for management interface  (hellt#310)
  bump num nics (hellt#308)
  update vqfx base image
  lowercase things
  Update vqfx Makefile (hellt#289)
  AOS-CX: Update base image and cpu (hellt#305)
  Update Dockerfile to install qemu-utils (hellt#304)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants