Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ember.js templates #9902

Merged
merged 8 commits into from
Mar 19, 2024

Conversation

c0rydoras
Copy link
Contributor

@c0rydoras c0rydoras commented Mar 16, 2024

Add support for ember.js .hbs templates (glimmer)

this is a redo of #8779

image
image
image


old version with incorrectly highlighted attributes and incorrectly highlighted has_pairs
image
image


old version with this being highlighted incorrectly in block statements
image
image


old version without highlights adjusted to helix
image

@c0rydoras c0rydoras changed the title add support for ember .hbs (glimmer) templates Add support for ember.js templates Mar 16, 2024
@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Mar 17, 2024
@c0rydoras c0rydoras force-pushed the feat/add-glimmer-support branch 5 times, most recently from 6ef5b52 to 258e665 Compare March 19, 2024 12:36
languages.toml Outdated Show resolved Hide resolved
runtime/queries/glimmer/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/glimmer/highlights.scm Outdated Show resolved Hide resolved
@the-mikedavis the-mikedavis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from a maintainer. labels Mar 19, 2024
@c0rydoras c0rydoras force-pushed the feat/add-glimmer-support branch from 258e665 to 3eeebb8 Compare March 19, 2024 14:25
@c0rydoras c0rydoras force-pushed the feat/add-glimmer-support branch from 3eeebb8 to 88ebcf0 Compare March 19, 2024 14:26
@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 19, 2024
@pascalkuthe pascalkuthe merged commit 427dd2f into helix-editor:master Mar 19, 2024
6 checks passed
@c0rydoras c0rydoras deleted the feat/add-glimmer-support branch March 20, 2024 07:15
Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Mar 26, 2024
* feat: add support for ember .hbs (glimmer) templates

* adjust highlights to helix

* highlight this correctly in block statements

* correctly highlight attributes

* correctly highlight hash_pair

* add newline to highlights.scm

* refactor: use #any-of and #eq instead of #match

* chore: add newline to languages.toml
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
* feat: add support for ember .hbs (glimmer) templates

* adjust highlights to helix

* highlight this correctly in block statements

* correctly highlight attributes

* correctly highlight hash_pair

* add newline to highlights.scm

* refactor: use #any-of and #eq instead of #match

* chore: add newline to languages.toml
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
* feat: add support for ember .hbs (glimmer) templates

* adjust highlights to helix

* highlight this correctly in block statements

* correctly highlight attributes

* correctly highlight hash_pair

* add newline to highlights.scm

* refactor: use #any-of and #eq instead of #match

* chore: add newline to languages.toml
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
* feat: add support for ember .hbs (glimmer) templates

* adjust highlights to helix

* highlight this correctly in block statements

* correctly highlight attributes

* correctly highlight hash_pair

* add newline to highlights.scm

* refactor: use #any-of and #eq instead of #match

* chore: add newline to languages.toml
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
* feat: add support for ember .hbs (glimmer) templates

* adjust highlights to helix

* highlight this correctly in block statements

* correctly highlight attributes

* correctly highlight hash_pair

* add newline to highlights.scm

* refactor: use #any-of and #eq instead of #match

* chore: add newline to languages.toml
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
* feat: add support for ember .hbs (glimmer) templates

* adjust highlights to helix

* highlight this correctly in block statements

* correctly highlight attributes

* correctly highlight hash_pair

* add newline to highlights.scm

* refactor: use #any-of and #eq instead of #match

* chore: add newline to languages.toml
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
* feat: add support for ember .hbs (glimmer) templates

* adjust highlights to helix

* highlight this correctly in block statements

* correctly highlight attributes

* correctly highlight hash_pair

* add newline to highlights.scm

* refactor: use #any-of and #eq instead of #match

* chore: add newline to languages.toml
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
* feat: add support for ember .hbs (glimmer) templates

* adjust highlights to helix

* highlight this correctly in block statements

* correctly highlight attributes

* correctly highlight hash_pair

* add newline to highlights.scm

* refactor: use #any-of and #eq instead of #match

* chore: add newline to languages.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants