Fix scroll track #9508
Merged
Fix scroll track #9508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
approved these changes
Feb 3, 2024
the-mikedavis
added
C-bug
|
Hmm so if borders are enabled the scroll line is still hidden? Also it seems we now have a branch ere we're the if and else if condition do the exact same thing here. That seems like codesmell to me at best a sign of a potential trial bug at worst |
|
Yeah, if we have borders the scroll line is hidden. The if condition is the actual scrollbar position and is painted with scroll_style.fg. |
pascalkuthe
approved these changes
Feb 9, 2024
cosmikwolf
pushed a commit
to cosmikwolf/helix
that referenced
this pull request
Feb 26, 2024
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #9498