Auto completion #805
Closed
Auto completion #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have another prototype here with idle timers: https://github.com/helix-editor/helix/tree/idle-timer Instant completion would then be an idle timer of zero. |
archseer
reviewed
Oct 3, 2021
Personally, I prefer to trigger immediately |
|
Triggering immediately = |
pickfire
reviewed
Oct 9, 2021
helix-term/src/commands.rs
Outdated
Comment on lines
3364
to
3377
| .map(|puns| match puns { | ||
| Some(puns) => puns.iter().any(|pun| pre_char.ends_with(pun)), | ||
| None => false, | ||
| }) | ||
| .or_else(|| { | ||
| doc.language_server().and_then(|cap| { | ||
| cap.capabilities() | ||
| .completion_provider | ||
| .as_ref() | ||
| .and_then(|cp| cp.trigger_characters.as_ref()) | ||
| .map(|puns| puns.iter().any(|pun| pre_char.ends_with(pun))) | ||
| }) | ||
| }) | ||
| .unwrap_or(false); |
There was a problem hiding this comment.
This part I find it a little bit complicated, I believe could be simplified.
|
I've merged #821, hopefully that's good enough |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Init implement auto completeion. Maybe the way is not elegant.