goto_file_impl: use relative path to open file #7965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
previously approved these changes
Aug 16, 2023
|
Fixes #1701 |
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
michaelBelsanti
force-pushed
the
relative_goto_file
branch
from
5b8179b to
33696b8
Compare
pascalkuthe
approved these changes
Aug 21, 2023
the-mikedavis
approved these changes
Aug 21, 2023
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the function to join the selected path with the parent of the document. It will use the working directory if doc.relative_path() returns None.