Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace new lsp for vlang #7760

Merged
merged 6 commits into from
Jul 30, 2023
Merged

replace new lsp for vlang #7760

merged 6 commits into from
Jul 30, 2023

Conversation

lydiandy
Copy link
Contributor

@lydiandy lydiandy commented Jul 27, 2023

replace new lsp for vlang

@pascalkuthe
Copy link
Member

The pipeline is not failing on master and the repo ist will reachale for me

It seems like you are switching to a different grammar here (and different language sever) which potentially requires query changes

@lydiandy
Copy link
Contributor Author

the old one has been archived: https://github.com/vlang/vls
here is the new one for vlang : https://github.com/v-analyzer/v-analyzer
see: https://blog.vosca.dev/meet-v-analyzer/

@lydiandy lydiandy changed the title fix vlang grammar fetch and build fail replace new lsp for vlang Jul 27, 2023
languages.toml Outdated Show resolved Hide resolved
runtime/queries/v/highlights.scm Outdated Show resolved Hide resolved
lydiandy and others added 2 commits July 29, 2023 01:04
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the textobjects.scm queries will need to be adjusted too

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Jul 30, 2023
@pascalkuthe pascalkuthe merged commit 57952c4 into helix-editor:master Jul 30, 2023
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
* fix vlang grammar fetch and build fail

* update highlights.scm for v-analyzer

* Update languages.toml

Co-authored-by: Michael Davis <mcarsondavis@gmail.com>

* Update runtime/queries/v/highlights.scm

Co-authored-by: Michael Davis <mcarsondavis@gmail.com>

* update scm for new lsp

* gen doc lang-support.md

---------

Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
* fix vlang grammar fetch and build fail

* update highlights.scm for v-analyzer

* Update languages.toml

Co-authored-by: Michael Davis <mcarsondavis@gmail.com>

* Update runtime/queries/v/highlights.scm

Co-authored-by: Michael Davis <mcarsondavis@gmail.com>

* update scm for new lsp

* gen doc lang-support.md

---------

Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants