Change dark_plus inlay-hints colors to more pleasant colors #7611
Conversation
|
I think you meant Dark Plus theme and this title is wrong. @mkblast Did you check out #6270 ? I agree that they look dreadful at the moment, I think they were hastily done to copy the VS Code default.. but in VS Code there are also other ways it is styled so it looks better. If a direct copy of the colors from the official theme are needed, maybe better to take them from the dark+ experimental version as discussed in the discussion? What do you think? Your colors look OK to me, but I think some others will want to input their opinion on this. |
mkblast
changed the title
|
I think a background colors is not needed. for me its too distracting since it has more contrast. However, I like the foreground color of dark+ experimental version way better than what i choose.
|
So do I, it would be cool to change your PR to that colour, it is then an official VS Code colour too :) |
|
Are we good with no background color or we wait for more input? |
the-mikedavis
changed the title
…itor#7611) * Changing code_dark inlay-hints colors. * Using dark_plus_experimental inlay hints is better ;)
…itor#7611) * Changing code_dark inlay-hints colors. * Using dark_plus_experimental inlay hints is better ;)
A little change to the
dark_plustheme.Before:
After:
