Use std::io::IsTerminal (stabilized in 1.70) over crossterm implementation.
#7605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
according to our Msrv policy we never bump our MSRV beyond that required by firefox stable which is currently at 1.66 (our msrv is 1.65 right now) and likely won't reach 1.70 this year. It's not worth breaking that policy for something that makes no functional difference |
|
Yup, just leaving it open for now 👍 |
|
while our msrv is new enough now this has conflicts and will only be useful once this removed from crossterm aswell (at which point we will have to update anyway). So I am closing this out. Thanks for contributing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crossterm-rs/crossterm#794