-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tree-sitter-cabal
#6996
Merged
Merged
Remove tree-sitter-cabal
#6996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think I added this prematurely. The upstream parser isn't mature enough, and segfaults on quite a few routine edits of `.cabal` files (e.g., those generated by `hpack`, or files with merge conflicts). I think we should drop this until it's more mature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably makes sense to remove the query files as well. Those are often broken by updates to the grammar repository so they may not help highlighting when adding cabal back
the-mikedavis
added
the
A-language-support
Area: Support for programming/text languages
label
May 8, 2023
Good shout, I'll do that. |
I'll regen docs when I get a chance soon |
the-mikedavis
approved these changes
May 9, 2023
pascalkuthe
approved these changes
May 9, 2023
Triton171
pushed a commit
to Triton171/helix
that referenced
this pull request
Jun 18, 2023
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I added this prematurely. The upstream parser isn't mature enough, and segfaults on quite a few routine edits of
.cabal
files (e.g., those generated byhpack
, or files with merge conflicts). I think we should drop this until it's more mature.