Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tree-sitter-cabal #6996

Merged
merged 2 commits into from
May 9, 2023
Merged

Remove tree-sitter-cabal #6996

merged 2 commits into from
May 9, 2023

Conversation

ocharles
Copy link
Contributor

@ocharles ocharles commented May 8, 2023

I think I added this prematurely. The upstream parser isn't mature enough, and segfaults on quite a few routine edits of .cabal files (e.g., those generated by hpack, or files with merge conflicts). I think we should drop this until it's more mature.

I think I added this prematurely. The upstream parser isn't mature enough, and segfaults on quite a few routine edits of `.cabal` files (e.g., those generated by `hpack`, or files with merge conflicts). I think we should drop this until it's more mature.
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably makes sense to remove the query files as well. Those are often broken by updates to the grammar repository so they may not help highlighting when adding cabal back

@the-mikedavis the-mikedavis added the A-language-support Area: Support for programming/text languages label May 8, 2023
@ocharles
Copy link
Contributor Author

ocharles commented May 9, 2023

Good shout, I'll do that.

@ocharles
Copy link
Contributor Author

ocharles commented May 9, 2023

I'll regen docs when I get a chance soon

@pascalkuthe pascalkuthe merged commit 8424f38 into helix-editor:master May 9, 2023
Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants