Add Amberwood theme #6924
Merged
Add Amberwood theme #6924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runtime/themes/amberwood.toml
Outdated
Comment on lines
78
to
79
| "ui.virtual" = { fg = "gray02" } | ||
| "ui.virtual.indent-guide" = { fg = "gray02" } |
There was a problem hiding this comment.
You might want to add a "ui.virtual.ruler" key and style it with something like { bg = "gray02" }. It inherits from ui.virtual by default so it will be a foreground ruler which can look odd. (Try :set rulers [80] to enable a ruler at 80 columns temporarily)
There was a problem hiding this comment.
Thank you @the-mikedavis for the pointer. much appreciated for the help. Please note that I have now updated the theme file with the changes and attached the updated screenshot above. Indeed without the change, it was difficult seeing where the ruler was. That was my bad. Sincere apologies, for the same. Thanks once again.
the-mikedavis
previously approved these changes
May 2, 2023
pascalkuthe
approved these changes
May 2, 2023
the-mikedavis
approved these changes
May 3, 2023
Triton171
pushed a commit
to Triton171/helix
that referenced
this pull request
Jun 18, 2023
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have created this theme , called "Amberwood" . Its a subtle dark theme. Can you please let me know if there is anything else that I will need to do , in order to get this merged please?
Thanks
After update (ruler bg color)