fix didChange notification offset encoding #6921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
added
C-bug
This was referenced Apr 30, 2023
|
Thanks for fixing it! If this isn't merged by Tuesday, I'll have the test to test it for a work day then |
the-mikedavis
approved these changes
Apr 30, 2023
the-mikedavis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rust-lang/rust-analyzer#14679
In #5894 I overlooked that the incremental sync code manually transcodes char positions to utf16 line/column offset. This could cause server crashes for LSP servers that support utf8 or utf32 when editing on the same line after a non-ascii character.
This issue has been noticed by quite a few people both on matrix and in various github comments (for example #6594 (comment)) altough we don't have an issue for it in our repo