-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make :toggle-option print the new value #6774
make :toggle-option print the new value #6774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a good usability improvement to me. One minor style nit: I think this code could be clear if we just extracted the value with let .. else and then just did let new_value = !old_value
.
52a407c
to
cafa26f
Compare
@pascalkuthe Nice! Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
b53c59b
to
96c6042
Compare
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
I think some kind of feedback is useful for this command. I chose to set the status line with format
key = new_value
. For example,:toggle lsp.enable
will set the status line tolsp.enable = false
orlsp.enable = true
after successfully applying updated config to the editor.