-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change smithy language server to the one from AWS #6572
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think any generally applicable changes from the Disney fork are upstreamed, so this LGTM. Since the goto definition issue is in both LSPs, I still think we should switch, but opening an issue on https://github.com/awslabs/smithy-language-server would be great!
Updating the installation instructions would be great too, but I know you're waiting on agreement for the PR.
Ah yes, sounds good. I'll open up an issue is that repo, thank you for your help :D. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for reviewing and merging! :D I updated the wiki to clarify that we're using the one from AWS: https://github.com/helix-editor/helix/wiki/How-to-install-the-default-language-servers#smithy |
Changes the current smithy language server to use the one from: https://github.com/awslabs/smithy-language-server
I've used both just fine(AWS one with VSCode and Disneys with helix) but I believe the AWS one is a bit nicer for general usage.
I'll update the wiki LS install instructions if this PR gets approved.