Skip to content

Conversation

90-008
Copy link
Contributor

@90-008 90-008 commented Aug 18, 2021

  • Add indents

NOTE: This only supports protobuf 3 syntax.

@90-008 90-008 marked this pull request as ready for review August 18, 2021 11:31
@archseer
Copy link
Member

Any reason you chose that grammar instead of https://github.com/mitchellh/tree-sitter-proto ? I think it looks fine otherwise 👍🏻

@90-008
Copy link
Contributor Author

90-008 commented Aug 18, 2021

Any reason you chose that grammar instead of mitchellh/tree-sitter-proto ? I think it looks fine otherwise 👍🏻

It's basically the same grammar, except the node names are camelCase, and some new grammar is added. I had started working on that so I continued working on it. (may be a good idea to upstream changes there in the future)

@archseer archseer merged commit 2f42b23 into helix-editor:master Aug 19, 2021
@archseer
Copy link
Member

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants