Skip to content

Conversation

@hunterliao29
Copy link
Contributor

close #4861

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Jan 20, 2023
@the-mikedavis the-mikedavis self-requested a review January 20, 2023 15:54
scope = "source.angular"
roots = ["angular.json"]
language-server = { command = "ngserver", args = ["--stdio", "--tsProbeLocations", "$(npm -g root)", "--ngProbeLocations", "$(npm -g root)"] }
file-types = ["ts", "html"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will conflict with the typscript and html file-types: all .ts and .html files will become angular and will use this language server configuration. See #3249

@hunterliao29
Copy link
Contributor Author

I think this is not feasible due to the limitation.
#2507 to use angular, typescript, html, css language server.
#3249 to set file type
And need to have option to set language server base on file type.

@danriedl
Copy link

Hey @hunterliao29, asking in favor of #4861.
As we do have now support for multiple language-servers could we reopen this, to get angular support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Angular support

3 participants