Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump git-repository from 0.31.0 to 0.32.0 #5476

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 9, 2023

Bumps git-repository from 0.31.0 to 0.32.0.

Release notes

Sourced from git-repository's releases.

git-repository v0.32.0

Bug Fixes

  • default author and committer time When needing to fallback to a default author or committer signature, the time from GIT_AUTHOR_DATE should only be used for the author and GIT_COMMITTER_DATE should only be used for the committer and not intermixed. This change enforces that constraint.

  • signature name and email resolution The name and email for the author and/or committer may come from different config files. For example, user.name may be set in the global config and user.email may come from the repository local config.

    This case was broken due to Personas.from_config_and_env() only looking in the last config section containing, for example, a "user" section. Thus if the user.name and user.email are split across multiple sections (i.e. originating from separate config files), the fallback name and email ("gitoxide" and "gitoxide@localhost") would be used.

    The solution is to use git_config::File::string() to lookup the name and email separately. The string() method correctly resolves the value by looking through all sections from all files in the correct order.

Other

  • name and email from different config sections The user.name, user.email, author.name, author.email, committer.name, and committer.email configuration may come from different sections from different config files. This new test exercises a couple of scenarios that are currently broken.

Reverted (BREAKING)

  • commiter_or_default(), author_or_default() and user_default(). This means that all methods that previously succeeded by adding a default will now fail.

    This is preferable over 'doing something' and also admits that gits guesswork that tries to find user information by querying the system is nothing we want to repeat.

Commit Statistics

  • 14 commits contributed to the release over the course of 9 calendar days.
  • 9 days passed between releases.
  • 4 commits were understood as conventional.
  • 0 issues like '(#ID)' were seen in commit messages

Commit Details

... (truncated)

Commits
  • ffb5b6a Release git-ref v0.23.0, git-config v0.15.0, git-command v0.2.2, git-diff v0....
  • 3036497 Merge branch 'signature-resolution'
  • d6c62bd fix tests
  • 4381a03 prepare changelogs prior to release
  • 0f7edc1 Merge branch 'signature-resolution'
  • d9b7df9 adapt to changes in git-repository
  • 87abb51 remove!: commiter_or_default(), author_or_default() and user_default().
  • a05b1c4 fix: default author and committer time
  • 53dd252 add explainers for asserts in test cases
  • 7200d71 increase crate size limits
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [git-repository](https://github.com/Byron/gitoxide) from 0.31.0 to 0.32.0.
- [Release notes](https://github.com/Byron/gitoxide/releases)
- [Changelog](https://github.com/Byron/gitoxide/blob/main/CHANGELOG.md)
- [Commits](GitoxideLabs/gitoxide@git-repository-v0.31.0...git-repository-v0.32.0)

---
updated-dependencies:
- dependency-name: git-repository
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added A-dependencies Area: Dependency rust Pull requests that update Rust code labels Jan 9, 2023
@pickfire pickfire merged commit 2d601d6 into master Jan 10, 2023
@pickfire pickfire deleted the dependabot/cargo/git-repository-0.32.0 branch January 10, 2023 00:12
kirawi pushed a commit to kirawi/helix that referenced this pull request Jan 25, 2023
…5476)

Bumps [git-repository](https://github.com/Byron/gitoxide) from 0.31.0 to 0.32.0.
- [Release notes](https://github.com/Byron/gitoxide/releases)
- [Changelog](https://github.com/Byron/gitoxide/blob/main/CHANGELOG.md)
- [Commits](GitoxideLabs/gitoxide@git-repository-v0.31.0...git-repository-v0.32.0)

---
updated-dependencies:
- dependency-name: git-repository
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant