Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply transactions to views lazily #4912

Merged
merged 9 commits into from
Nov 29, 2022
Merged

Apply transactions to views lazily #4912

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7f91f18
Remove eager application of transactions to all views
the-mikedavis Nov 27, 2022
4a2e828
Revert "Don't apply transactions to Views in undo/redo"
the-mikedavis Nov 27, 2022
58753e6
Sync changes between doc and view on switch
the-mikedavis Nov 27, 2022
42f2ff0
Remove calls to View::apply in undo/redo/earlier/later
the-mikedavis Nov 27, 2022
97f2557
Sync changes with view in undo/redo/earlier/later
the-mikedavis Nov 27, 2022
121585b
Call View::apply within Document::append_changes_to_history
the-mikedavis Nov 27, 2022
6e9408f
Use lowest common ancestor search in History::changes_since
the-mikedavis Nov 27, 2022
0cfc5d0
Add a test case for undo/redo across splits
the-mikedavis Nov 27, 2022
dc1899e
Sync all document changes on view focus
the-mikedavis Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a test case for undo/redo across splits
  • Loading branch information
@the-mikedavis
the-mikedavis committed Nov 27, 2022
commit 0cfc5d02a9371505b9511c32468714c16f350152
10 changes: 10 additions & 0 deletions helix-term/tests/test/splits.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,5 +151,15 @@ async fn test_changes_in_splits_apply_to_all_views() -> anyhow::Result<()> {
// was not updated and after the `kd` step, pointed outside of the document.
test(("#[|]#", "<C-w>v[<space><C-s><C-w>wkd<C-w>qd", "#[|]#")).await?;

// Transactions are applied to the views for windows lazily when they are focused.
// This case panics if the transactions and inversions are not applied in the
// correct order as we switch between windows.
test((
"#[|]#",
"[<space>[<space>[<space><C-w>vuuu<C-w>wUUU<C-w>quuu",
"#[|]#",
))
.await?;

Ok(())
}