Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: code actions - document edits #478

Merged
merged 18 commits into from
Jul 24, 2021
Merged

feat: code actions - document edits #478

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
21bf614
wip: Code actions
archseer Jun 14, 2021
3a7b921
fix(term): use current macro instead Context::context
gbaranski Jul 21, 2021
cdfb6f2
feat(lsp): set code_action capabilities
gbaranski Jul 21, 2021
bc62f03
feat(term): set SPC-a to code_action
gbaranski Jul 21, 2021
5d253df
feat(term): wip on applying code actions
gbaranski Jul 21, 2021
eeca3b5
deps: `cargo update`
gbaranski Jul 21, 2021
70db2f1
feat(term): applying code actions edits
gbaranski Jul 21, 2021
9dcdb55
fix(term): cleanup of apply_edit
gbaranski Jul 22, 2021
32facf1
fix(term): applying edits as a whole thing instead one by one
gbaranski Jul 22, 2021
70dfc98
refactor(term): move apply_edits below
gbaranski Jul 22, 2021
1661bf0
fix(term): improve unimplemented messages for further investigation
gbaranski Jul 22, 2021
daeb8e5
fix(term): change code action command comment
gbaranski Jul 22, 2021
1dfc39a
Merge branch 'master' into code-action
gbaranski Jul 22, 2021
b3f0d72
fix(term): add matching `}`
gbaranski Jul 22, 2021
36499a8
fix(term): cleanup, todo!() on workspace edit
gbaranski Jul 23, 2021
02c13b8
fix(term): remove unrelated workspace_symbol_picker
gbaranski Jul 23, 2021
6dd84e1
fix(term): apply cargo-clippy suggestions
gbaranski Jul 23, 2021
4907c63
fix(term): replace todo!'s with editor.set_error
gbaranski Jul 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(term): use current macro instead Context::context
  • Loading branch information
@gbaranski
gbaranski committed Jul 21, 2021
commit 3a7b92111a9b358f47460dc6d7594043b6632415
6 changes: 3 additions & 3 deletions helix-term/src/commands.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2092,7 +2092,7 @@ fn symbol_picker(cx: &mut Context) {
}

pub fn workspace_symbol_picker(cx: &mut Context) {
let (view, doc) = cx.current();
let (view, doc) = current!(cx.editor);

let language_server = match doc.language_server() {
Some(language_server) => language_server,
Expand All @@ -2113,7 +2113,7 @@ pub fn workspace_symbol_picker(cx: &mut Context) {
|symbol| (&symbol.name).into(),
move |editor: &mut Editor, symbol, _action| {
push_jump(editor);
let (view, doc) = editor.current();
let (view, doc) = current!(editor);

// if let Some(range) =
// lsp_range_to_range(doc.text(), symbol.location.range, offset_encoding)
Expand All @@ -2130,7 +2130,7 @@ pub fn workspace_symbol_picker(cx: &mut Context) {
}

pub fn code_action(cx: &mut Context) {
let (view, doc) = cx.current();
let (view, doc) = current!(cx.editor);

let language_server = match doc.language_server() {
Some(language_server) => language_server,
Expand Down