add redraw command #4354
Merged
add redraw command #4354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrvidal
commented
Oct 18, 2022
|
|
||
| let callback = Box::pin(async move { | ||
| let call: job::Callback = Box::new(|_editor, compositor| { | ||
| compositor.clear().expect("unable to redraw"); |
There was a problem hiding this comment.
Not sure how OK it is to panic here. I was looking how the error from terminal.clear() is propagated and it ultimately panics on resize() so... 🤷
There was a problem hiding this comment.
I think panicking on this is ok. To not panic we could say
editor.set_error("Could not redraw terminal")but if we can't draw the terminal then I doubt that would end up showing up 😄
the-mikedavis
added
A-helix-term
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
the-mikedavis
approved these changes
Oct 19, 2022
|
Merged this but had to revert in master, |
freqmod
pushed a commit
to freqmod/helix
that referenced
this pull request
Feb 8, 2023
* add redraw command * update docs * Update helix-term/src/commands/typed.rs Co-authored-by: Michael Davis <mcarsondavis@gmail.com> * update docs Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if we want this, as per this comment, but anyway, here it is.
Fixes #4350