Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move helix-view/tests/*txt files to txts subdirectory #372

Merged
merged 2 commits into from
Jun 25, 2021

Conversation

teenjuna
Copy link
Contributor

I just think it's a bit cleaner since there might be .rs files in this directory later.

@kirawi
Copy link
Member

kirawi commented Jun 24, 2021

Maybe rename it to tests/encoding?

@cessen
Copy link
Contributor

cessen commented Jun 24, 2021

Yeah, I think tests/encoding probably makes more sense. That way, in the future, each category of test can get its own directory for the data/text files it needs.

@teenjuna
Copy link
Contributor Author

@cessen done!

@archseer archseer merged commit c688288 into helix-editor:master Jun 25, 2021
cessen pushed a commit to cessen/helix that referenced this pull request Jun 26, 2021
* Move helix-view/tests/*txt files to txts subdirectory

* Rename tests/txts to tests/encoding
kirawi added a commit to kirawi/helix that referenced this pull request Jun 28, 2021
archseer pushed a commit that referenced this pull request Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants