Change MonokaiProSpectrum theme error background from red to magenta. #3627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Text painted in red (JSON object keys for example) is not visible in case of error. Change to magenta can fix this.
the-mikedavis
approved these changes
Sep 1, 2022
thomasskk
pushed a commit
to thomasskk/helix
that referenced
this pull request
Sep 9, 2022
…helix-editor#3627) Co-authored-by: Fanda Vacek <fvacek@elektroline.cz>
jdrst
pushed a commit
to jdrst/helix
that referenced
this pull request
Sep 13, 2022
…helix-editor#3627) Co-authored-by: Fanda Vacek <fvacek@elektroline.cz>
herkhinah
pushed a commit
to herkhinah/helix
that referenced
this pull request
Dec 11, 2022
…helix-editor#3627) Co-authored-by: Fanda Vacek <fvacek@elektroline.cz>
|
@fvacek This still has a terrible contrast: Do you think we could opt for a darker shade? PS: Problem appears to be that "magenta" is a terminal built-in color. It should be defined with a hex code to be reliable across terminal themes. Related: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text painted in red (JSON object keys for example) is not visible in case
of error. Change to magenta can fix this.
before:
after:
