Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: snazzy #3583

Closed
Closed

Conversation

AlexanderBrevig
Copy link
Contributor

passes linter from #3234
image

@AlexanderBrevig
Copy link
Contributor Author

@nrdxp please sanity check my choices :)

@Omnikar
Copy link
Contributor

Omnikar commented Aug 27, 2022

Well, this is PR 24, you almost covered the whole first page

@AlexanderBrevig
Copy link
Contributor Author

AlexanderBrevig commented Aug 27, 2022

Yeah, I'm done now.
I feel themes are important for a newcomer's first impressions of Helix. The current state of the themes is not good enough in my opinion. This is my effort to at least make it better.

@Omnikar
Copy link
Contributor

Omnikar commented Aug 27, 2022

24 hour Github insights 😆
image

@AlexanderBrevig
Copy link
Contributor Author

How many hours did you spend on Helix contributions today? Are you trying to make me feel bad?

I did offer to close them all and make a new PR if a core member asks me to.

@nrdxp sorry for derailing here, I were meaning to ask for your input on this.

@Omnikar
Copy link
Contributor

Omnikar commented Aug 27, 2022

Are you trying to make me feel bad?

No not at all, thanks a lot for working on all of this, I just found the sheer quantity of PRs a bit funny.

@AlexanderBrevig
Copy link
Contributor Author

AlexanderBrevig commented Aug 27, 2022

Yeah :p it became quite a bit more work than I initially intended. Does reflect the feeling I had that the themes were lacking in some details.

Sorry for getting passive-aggressive. I'm tired, going to bed now.

@archseer
Copy link
Member

I think all of these could have been separate commits in a single PR?

@AlexanderBrevig
Copy link
Contributor Author

I think all of these could have been separate commits in a single PR?

Yeah. Do you want me to close them and make a new one?

@archseer
Copy link
Member

If you don't mind, it would be slightly easier to review and merge

@AlexanderBrevig
Copy link
Contributor Author

How should I indicate changes which have already been approved by original authors?
I'll close and recreate tonight 👍

@AlexanderBrevig
Copy link
Contributor Author

Moved to bulk PR #3587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants