feat(selection-indices): zero pad according to max number of digits. #13386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cotneit
reviewed
Apr 21, 2025
| @@ -55,6 +55,7 @@ | |||
| | `insert-final-newline` | Whether to automatically insert a trailing line-ending on write if missing | `true` | | |||
| | `trim-final-newlines` | Whether to automatically remove line-endings after the final one on write | `false` | | |||
| | `trim-trailing-whitespace` | Whether to automatically remove whitespace preceding line endings on write | `false` | | |||
| | `padding_selection_index_register` | Whether to align selection indices register with zero padding | `false` | | |||
There was a problem hiding this comment.
pad-selection-index-register would probably be a better name for this option
nik-rev
reviewed
Apr 21, 2025
Comment on lines
+49
to
+52
| let mut number_of_digits = 0 as usize; | ||
| if editor.config().padding_selection_index_register { | ||
| number_of_digits = (selections.ilog10() + 1) as usize; | ||
| } |
There was a problem hiding this comment.
Suggested change
| let mut number_of_digits = 0 as usize; | |
| if editor.config().padding_selection_index_register { | |
| number_of_digits = (selections.ilog10() + 1) as usize; | |
| } | |
| let number_of_digits = if editor.config().padding_selection_index_register { | |
| selections.ilog10() as usize + 1 | |
| } else { 0 } |
|
I'm not sure if this deserves a config option. Something like #13354 with a flag such as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #13356
First oss contribution, let me know if something is wrong.