Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve completion item #1315

Merged
merged 1 commit into from
Dec 25, 2021
Merged

Resolve completion item #1315

merged 1 commit into from
Dec 25, 2021

Conversation

Gabrielbdd
Copy link
Contributor

This one solves the issue: 1313

That is my first contribution to a Rust project, and to this project, so I'm really open to receive suggestions 😄

Talking about the solution, I adopted the suggestions that I received on the Matrix chat, from the user "archseer".

The suggestion was to request the language server directly from Completion component, and use block_on since this component does not have any way of enqueuing async jobs yet.

archseer
archseer requested changes Dec 21, 2021
View reviewed changes
helix-lsp/src/client.rs Outdated Show resolved Hide resolved
helix-term/src/ui/completion.rs Outdated Show resolved Hide resolved
helix-term/src/ui/completion.rs Outdated Show resolved Hide resolved
helix-term/src/ui/completion.rs Outdated Show resolved Hide resolved
helix-term/src/ui/completion.rs Outdated Show resolved Hide resolved
helix-term/src/ui/completion.rs Outdated Show resolved Hide resolved
@Gabrielbdd Gabrielbdd force-pushed the feature/1313-resolve-completion-item branch from f1b9b5a to f33a938 Compare December 21, 2021 02:51
@Gabrielbdd Gabrielbdd requested a review from archseer December 21, 2021 18:28
@Gabrielbdd Gabrielbdd marked this pull request as ready for review December 21, 2021 20:40
@Gabrielbdd Gabrielbdd force-pushed the feature/1313-resolve-completion-item branch from f33a938 to fa63de0 Compare December 22, 2021 00:58
archseer
archseer requested changes Dec 23, 2021
View reviewed changes
Copy link
Member

@archseer archseer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only want to call resolve if client.capabilities().completion_provider.resolve_provider == Some(true). Other than that it looks 👍🏻

@Gabrielbdd Gabrielbdd force-pushed the feature/1313-resolve-completion-item branch from fa63de0 to e34d830 Compare December 23, 2021 16:11
@sudormrfbin sudormrfbin linked an issue Dec 23, 2021 that may be closed by this pull request
Extend completion to support language servers which requires an additional "completion item resolve" request #1313
Closed
@Gabrielbdd Gabrielbdd requested a review from archseer December 23, 2021 18:54
archseer
archseer approved these changes Dec 25, 2021
View reviewed changes
Copy link
Member

@archseer archseer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🎉

@archseer archseer merged commit 5d7b5db into helix-editor:master Dec 25, 2021
@the-mikedavis the-mikedavis mentioned this pull request Apr 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WindSoilder WindSoilder WindSoilder left review comments

@pickfire pickfire pickfire left review comments

@archseer archseer archseer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend completion to support language servers which requires an additional "completion item resolve" request
4 participants
@Gabrielbdd @archseer @pickfire @WindSoilder