Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default-run = "hx" to helix-term/Cargo.toml #1244

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

Omnikar
Copy link
Contributor

@Omnikar Omnikar commented Dec 9, 2021

Following the addition of xtask, cargo run has multiple possible targets, necessitating the usage of the less convenient cargo run --bin hx to run Helix during development. This allows cargo run to be used to run hx.

Following the addition of `xtask`, `cargo run` has multiple possible
targets, necessitating the usage of `cargo run --bin hx` to run Helix
during development. This allows `cargo run` to be used to run `hx`.
@archseer
Copy link
Member

archseer commented Dec 9, 2021

Does this need to sit inside helix-term or on the workspace level Cargo.toml?

@Omnikar
Copy link
Contributor Author

Omnikar commented Dec 9, 2021

If it were added to the top-level Cargo.toml, it'd mean adding a [package] section to it, which you can't actually do without having to add the required [package] fields like name etc., so I do think it makes more sense to put it in helix-term.

@archseer archseer merged commit 44681c5 into helix-editor:master Dec 10, 2021
@Omnikar Omnikar deleted the default-run branch December 10, 2021 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants