Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mojo LSP configuration to conform to magic introduction #12195

Merged

Conversation

allemand-instable
Copy link
Contributor

fixes mojo-lsp not working due to mojo binaries being moved to magic environment

(one could also learn about modular-cli deprecation here)

using the current language configuration (mojo command)

hx --health mojo
Configured language servers:
  ✘ mojo-lsp-server: 'mojo-lsp-server' not found in $PATH
Configured debug adapter: None
Configured formatter: mojo
Binary for formatter: 'mojo' not found in $PATH
Highlight queries: ✓
Textobject queries: ✓
Indent queries: ✓

when updated to magic command:

hx --health mojo
Configured language servers:
  ✓ magic: /Users/instable/.modular/bin/magic
Configured debug adapter: None
Configured formatter: magic
Binary for formatter: /Users/instable/.modular/bin/magic
Highlight queries: ✓
Textobject queries: ✓
Indent queries: ✓

also tested it in a mojo project on my machine

allemand-instable and others added 2 commits December 5, 2024 18:04
fixes mojo-lsp not working due to mojo binaries being moved to magic environment

- updated mojo-lsp configuration to conform to magic introduction :
    - https://docs.modular.com/magic/
@the-mikedavis the-mikedavis merged commit a6f80c5 into helix-editor:master Dec 5, 2024
@allemand-instable allemand-instable deleted the mojo-lsp-magic-update branch December 5, 2024 22:57
GladkihEgor pushed a commit to GladkihEgor/helix that referenced this pull request Jan 4, 2025
diucicd pushed a commit to diucicd/helix that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants