fix: simplify text reflowing strategy to improve language compatibility #12048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: spx01 <42381535+spx01@users.noreply.github.com>
the-mikedavis
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Ideally we want to remove textwrap and reimplement :reflow in terms of the soft wrapping functionality (#11738). This is a tiny change though so I think it'd be ok to merge anyways
GladkihEgor
pushed a commit
to GladkihEgor/helix
that referenced
this pull request
Jan 4, 2025
diucicd
pushed a commit
to diucicd/helix
that referenced
this pull request
Jan 8, 2025
rmburg
pushed a commit
to rmburg/helix
that referenced
this pull request
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The the way the
textwrapcrate is configured results in the reflow command utilizing a more sophisticated word separator (WordSeparator::UnicodeBreakProperties). As there is currently no mechanism for language-aware reflowing, this approach results in issues like links breaking from their labels in Markdown (#12003). Explicitly using the simpler ASCII space separator addresses this issue and, in my opinion, serves as a better default behavior.