Large Gruvbox refactoring #10773

Chirikumbrah · 2024-05-16T10:00:30Z

Not so long ago I completely switched from Dracula to Gruvbox and I decided to make it more comfortable according to NVim Gruvbox colors.

I changed operator color with some other colors and disabled some bold fonts:

I also improved cursor/cursorline colors and made cursor color the same as the mode color. You can notice that primary cursorline is a bit lighter:

Normal mode with multicursor:
Selection mode with multicursor:
Insert mode with multicursor:

Now, diagnostics:
I decided to choose diagnostics colours according to their severity level:

Hint - aqua
Info - yellow
Sorry for no image but I didn't find any examples :)
Warning - orange and Error - red

I hope you will like theese changes and I am open to your improvements :)

justinesmithies · 2024-05-16T11:34:04Z

Nice ! I use gruvbox and that is an improvement indeed.
Fingers crossed it's accepted.

Locorock · 2024-05-16T12:23:18Z

A few things that left me puzzled about this:

How does this affect downstream themes like gruvbox light?
I'm pretty sure you should merge refactor(themes): gruvbox warnings to yellow1 #10506
shouldn't we base this theme off https://github.com/morhetz/gruvbox rather than https://github.com/ellisonleao/gruvbox.nvim?
if you're basing this off neovim gruvbox, why are you removing bold functions?

Now for some personal opinions:

diagnostics for hints/warnings have mismatched colors
dimming text for warning makes spotting errors really hard, this is even worse for the light theme
rust variables end up getting colored when used in expressions, not sure if this is intended or not
operators being the same color of operands makes code less legible
there are also some oddities with diagnostic priority which i wasn't able to pinpoint, not sure if this is the theme's fault

Chirikumbrah · 2024-05-16T13:30:01Z

How does this affect downstream themes like gruvbox light? Also i'm pretty sure you should merge #10506

I think orange is more suitable for warnings and yellow for infos, so I will change colors there.

Locorock · 2024-05-16T13:54:07Z

How does this affect downstream themes like gruvbox light? Also i'm pretty sure you should merge #10506

I think orange is more suitable for warnings and yellow for infos, so I will change colors there.

that would be the case but red and orange are quite hard to differentiate in gruvbox (especially with the light theme)

runtime/themes/gruvbox.toml

Chirikumbrah · 2024-05-18T07:54:34Z

operators being the same color of operands makes code less legible

I brought the purple1 back)

Chirikumbrah · 2024-05-18T08:00:34Z

if you're basing this off neovim gruvbox, why are you removing bold functions?

Because I didn't notice that functions are bold in the gruvbox.nvim and for me it is not so convinient. NeoVim's example below)

Chirikumbrah · 2024-05-18T08:17:21Z

dimming text for warning makes spotting errors really hard, this is even worse for the light theme

Only unnecessary objects are dimmed)

diagnostics for hints/warnings have mismatched colors

rust variables end up getting colored when used in expressions, not sure if this is intended or not

there are also some oddities with diagnostic priority which i wasn't able to pinpoint, not sure if this is the theme's fault

I agree, but could you please suggest some better solutions for some colors?
To be honest I don't know the better way to prioritize diagnostics colors, but yes, in the light themes orange and red are quite the same.

And thank you for your participation :)

Chirikumbrah · 2024-05-18T08:27:27Z

I'm pretty sure you should merge refactor(themes): gruvbox warnings to yellow1 #10506

The main question for me in this case is will it be ok if I set yellow for warnings and aqua for both hints and infos?)

Locorock · 2024-05-18T14:38:58Z

I agree, but could you please suggest some better solutions for some colors? To be honest I don't know the better way to prioritize diagnostics colors, but yes, in the light themes orange and red are quite the same.

I think the current diagnostic colors are fine:

Red for errors
Yellow for warnings
Aqua for hints
Blue for info

Now the real question becomes how do we handle diagnostic information which is not in the original theme, namely Unnecessary and Deprecated:

Deprecated seems straightforward enough, strikethrough seems like a standard at this point
Unnecessary is a bit more complex, adding dimming might be fine but, talking about gutter dots here, helix considers unnecessary diagnostics as warnings, so the colors are always going to be mismatched. Realistically speaking i think we're better off leaving unnecessary diagnostics with the default behaviour, at least until helix handles gutter diagnostics correctly.

Chirikumbrah · 2024-05-18T21:22:48Z

Red for errors

Yellow for warnings

Aqua for hints

Blue for info

Made so, but aqua for info and blue for hints as it was before :)

i think we're better off leaving unnecessary diagnostics with the default behaviour

I commented this line for future changes.

shouldn't we base this theme off https://github.com/morhetz/gruvbox rather than https://github.com/ellisonleao/gruvbox.nvim?

Probably we should, by the way, but I used gruvbox theme only with NeoVim. Not Vim. So for me it's easier to compare this theme with NeoVim's implementation.
If you have any additional suggestions, I'd be happy to discuss them)

runtime/themes/gruvbox.toml

Chirikumbrah · 2024-05-20T06:07:56Z

@Locorock, I also set diff.delta color to yellow as for the color of warnings :)

Chirikumbrah · 2024-06-15T12:19:26Z

@archseer, @kirawi
What do you think about my PR?)
Merge please when you'll have a time if everything is fine :)

runtime/themes/gruvbox.toml

* gruvbox refactoring * removed unnecessary lines * set purple1 for operators * changed diagnostics colors * removed some unnecessary lines * set diff.delta color to yellow * removed some tag colors

* Add new color theme 'iroaseta' * Update runtime/themes/iroaseta.toml Co-authored-by: postsolar <120750161+postsolar@users.noreply.github.com> * Update iroaseta.toml Add virtual jump label theme setting * Update runtime/themes/iroaseta.toml Co-authored-by: Michael Davis <mcarsondavis@gmail.com> * Update iroaseta.toml update storage. keyword.storage. according to suggestion, and update color. * Update iroaseta.toml remove unused palette * Update iroaseta.toml add missing setting for bufferline * Update iroaseta.toml update diagnostic fg color * Update iroaseta.toml I made the config more comprehensive and took all available themes settings from the manual. Some are commented out though. * Update iroaseta.toml add missing colors * Update iroaseta.toml Made some final adjustments to the color theme to improve visibility and reduce eye strain. * Update runtime/themes/iroaseta.toml Co-authored-by: Michael Davis <mcarsondavis@gmail.com> * Update runtime/themes/iroaseta.toml Co-authored-by: Michael Davis <mcarsondavis@gmail.com> * Update iroaseta.toml remove redundant settings * Update iroaseta.toml update color name --------- Co-authored-by: postsolar <120750161+postsolar@users.noreply.github.com> Co-authored-by: Michael Davis <mcarsondavis@gmail.com> Large Gruvbox refactoring (helix-editor#10773) * gruvbox refactoring * removed unnecessary lines * set purple1 for operators * changed diagnostics colors * removed some unnecessary lines * set diff.delta color to yellow * removed some tag colors Delay auto-save until exiting insert mode (helix-editor#11047) Saving while in insert mode causes issues with the modification indicator and this is very easy to reproduce with the current state of the auto-save hook. We can tweak the hook slightly to await the mode switch out of insert mode to perform the save. The debounce is preserved: if you save and then immediately exit insert mode the debounce will be respected. If the debounce lapses while you are in insert mode, the save occurs as you switch out of insert mode immediately. VHDL highlights.scm improvement (helix-editor#10845) Fix homebrew formula link (helix-editor#11058) Co-authored-by: Mark Murphy <mail@markmurphydev.com> build(deps): bump the rust-dependencies group with 3 updates (helix-editor#11072) Bumps the rust-dependencies group with 3 updates: [log](https://github.com/rust-lang/log), [serde_json](https://github.com/serde-rs/json) and [cc](https://github.com/rust-lang/cc-rs). Updates `log` from 0.4.21 to 0.4.22 - [Release notes](https://github.com/rust-lang/log/releases) - [Changelog](https://github.com/rust-lang/log/blob/master/CHANGELOG.md) - [Commits](rust-lang/log@0.4.21...0.4.22) Updates `serde_json` from 1.0.117 to 1.0.120 - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](serde-rs/json@v1.0.117...v1.0.120) Updates `cc` from 1.0.100 to 1.0.104 - [Release notes](https://github.com/rust-lang/cc-rs/releases) - [Changelog](https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md) - [Commits](rust-lang/cc-rs@cc-v1.0.100...cc-v1.0.104) --- updated-dependencies: - dependency-name: log dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust-dependencies - dependency-name: serde_json dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust-dependencies - dependency-name: cc dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore: update cairo tree sitter + queries (helix-editor#11067) Bump time from broken version (0.3.23) (helix-editor#11065) Tell language servers that Helix can request formatting (helix-editor#11064) Without providing the formatting capability, the language server might not advertise its ability to format in return, causing the :format command to be broken. Override far too dark cursorline (helix-editor#11071) Add hsc filetype to haskell (helix-editor#11074)

gruvbox refactoring

2e1e14d

Chirikumbrah changed the title ~~Large Gruvbox refactoring.~~ Large Gruvbox refactoring May 16, 2024

archseer reviewed May 16, 2024

View reviewed changes

runtime/themes/gruvbox.toml Outdated Show resolved Hide resolved

Chirikumbrah added 2 commits May 18, 2024 10:43

removed unnecessary lines

ae5ceef

set purple1 for operators

b59723e

kirawi added C-enhancement Category: Improvements A-theme Area: Theme and appearence related labels May 18, 2024

changed diagnostics colors

2ad1647

archseer reviewed May 20, 2024

View reviewed changes

runtime/themes/gruvbox.toml Outdated Show resolved Hide resolved

removed some unnecessary lines

392a2e3

set diff.delta color to yellow

6caf005

Chirikumbrah force-pushed the gruvbox-theme-refactoring branch from 92ddffa to 6caf005 Compare May 20, 2024 06:12

Chirikumbrah force-pushed the gruvbox-theme-refactoring branch from 9c1e3fd to 6caf005 Compare June 15, 2024 12:15

Merge branch 'master' into gruvbox-theme-refactoring

4cd2a10

the-mikedavis reviewed Jun 15, 2024

View reviewed changes

runtime/themes/gruvbox.toml Outdated Show resolved Hide resolved

Chirikumbrah added 2 commits June 21, 2024 08:00

Merge branch 'master' into gruvbox-theme-refactoring

26ed8cc

removed some tag colors

9069411

Chirikumbrah force-pushed the gruvbox-theme-refactoring branch from 38fbf9e to 9069411 Compare June 21, 2024 05:01

the-mikedavis approved these changes Jun 26, 2024

View reviewed changes

pascalkuthe approved these changes Jun 26, 2024

View reviewed changes

pascalkuthe merged commit b4811f7 into helix-editor:master Jun 26, 2024
6 checks passed

Chirikumbrah deleted the gruvbox-theme-refactoring branch June 30, 2024 12:34

a3lem mentioned this pull request Jul 1, 2024

Gruvbox light theme. Fix cursorline readability after #10773. #11071

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Large Gruvbox refactoring #10773

Large Gruvbox refactoring #10773

Chirikumbrah commented May 16, 2024 •

edited

Loading

justinesmithies commented May 16, 2024

Locorock commented May 16, 2024 •

edited

Loading

Chirikumbrah commented May 16, 2024

Locorock commented May 16, 2024

Chirikumbrah commented May 18, 2024

Chirikumbrah commented May 18, 2024 •

edited

Loading

Chirikumbrah commented May 18, 2024

Chirikumbrah commented May 18, 2024

Locorock commented May 18, 2024 •

edited

Loading

Chirikumbrah commented May 18, 2024 •

edited

Loading

Chirikumbrah commented May 20, 2024

Chirikumbrah commented Jun 15, 2024 •

edited

Loading

Large Gruvbox refactoring #10773

Large Gruvbox refactoring #10773

Conversation

Chirikumbrah commented May 16, 2024 • edited Loading

Not so long ago I completely switched from Dracula to Gruvbox and I decided to make it more comfortable according to NVim Gruvbox colors.

justinesmithies commented May 16, 2024

Locorock commented May 16, 2024 • edited Loading

Chirikumbrah commented May 16, 2024

Locorock commented May 16, 2024

Chirikumbrah commented May 18, 2024

Chirikumbrah commented May 18, 2024 • edited Loading

Chirikumbrah commented May 18, 2024

Chirikumbrah commented May 18, 2024

Locorock commented May 18, 2024 • edited Loading

Chirikumbrah commented May 18, 2024 • edited Loading

Chirikumbrah commented May 20, 2024

Chirikumbrah commented Jun 15, 2024 • edited Loading

Chirikumbrah commented May 16, 2024 •

edited

Loading

Locorock commented May 16, 2024 •

edited

Loading

Chirikumbrah commented May 18, 2024 •

edited

Loading

Locorock commented May 18, 2024 •

edited

Loading

Chirikumbrah commented May 18, 2024 •

edited

Loading

Chirikumbrah commented Jun 15, 2024 •

edited

Loading