Fix moving with arrow keys in prompt #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QiBaobin
approved these changes
Nov 11, 2021
archseer
reviewed
Nov 11, 2021
helix-term/src/ui/prompt.rs
Outdated
| @@ -430,8 +430,8 @@ impl Component for Prompt { | |||
| } | |||
| alt!('b') | alt!(Left) => self.move_cursor(Movement::BackwardWord(1)), | |||
| alt!('f') | alt!(Right) => self.move_cursor(Movement::ForwardWord(1)), | |||
| ctrl!('b') | ctrl!(Left) => self.move_cursor(Movement::BackwardChar(1)), | |||
| ctrl!('f') | ctrl!(Right) => self.move_cursor(Movement::ForwardChar(1)), | |||
| ctrl!('b') | ctrl!(Left) | key!(Left) => self.move_cursor(Movement::BackwardChar(1)), | |||
There was a problem hiding this comment.
You should replace the ctrl!() mapping with key!()
There was a problem hiding this comment.
Done! I was thinking about that, but i didnt do it because it was working before with ctrl too, so i wasnt sure if that was intentional.
There was a problem hiding this comment.
Yeah looks like it was a bug when transcribing the events: efc2b4c#diff-910b0deb36d6f016258fafae83ea994d924230f49ab46dce71ff326a4a06e3efL456
There was a problem hiding this comment.
Ah I see, key!() only matches the key with no modifiers, hmm. I think it's okay in this case
ath3
force-pushed
the
fix-prompt-arrow
branch
from
1e06f26 to
4eb4264
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.